laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[HOS-313] state.js: when a routing error occurs, delete it

Browse Source 
In some cases, a routing failure can cause the failure to be cached. When the
router has a cached failure, pushing such a route will never call
routeChangeComplete, and thus on_load event will never be fired for that route.

Purposely clearing the error from the router allows the page to properly load
on subsequent attempts without refreshing the app.
This commit is contained in:
Masen Furer 2024-11-20 22:59:00 -08:00
parent 681b616000
commit 90baa60d5d
No known key found for this signature in database
GPG Key ID: 2AE2BD5531FF94F4
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
reflex/.templates/web/utils/state.js
View File

@ -762,7 +762,7 @@ export const useEventLoop = (
window.onunhandledrejection = function (event) { window.onunhandledrejection = function (event) {
addEvents([ addEvents([
Event(`${exception_state_name}.handle_frontend_exception`, { Event(`${exception_state_name}.handle_frontend_exception`, {
stack: event.reason.stack, stack: event.reason?.stack,
component_stack: "", component_stack: "",
}), }),
]); ]);
@ -837,11 +837,20 @@ export const useEventLoop = (
} }
}; };
const change_complete = () => addEvents(onLoadInternalEvent()); const change_complete = () => addEvents(onLoadInternalEvent());
const change_error = () => {
// Remove cached error state from router for this page, otherwise the
// page will never send on_load events again.
if (router.components[router.pathname].error) {
delete router.components[router.pathname].error;
}
}
router.events.on("routeChangeStart", change_start); router.events.on("routeChangeStart", change_start);
router.events.on("routeChangeComplete", change_complete); router.events.on("routeChangeComplete", change_complete);
router.events.on("routeChangeError", change_error);
return () => { return () => {
router.events.off("routeChangeStart", change_start); router.events.off("routeChangeStart", change_start);
router.events.off("routeChangeComplete", change_complete); router.events.off("routeChangeComplete", change_complete);
router.events.off("routeChangeError", change_error);
}; };
}, [router]); }, [router]);