fix appearance broken by #3812 (#4403)

* fix appearance broken by #3812

* fix again to pass tests
This commit is contained in:
Thomas Brandého 2024-11-20 11:12:52 -08:00 committed by GitHub
parent 229df1ce09
commit 681b616000
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -850,8 +850,6 @@ class App(MiddlewareMixin, LifespanMixin):
if self.theme is not None:
# If a theme component was provided, wrap the app with it
app_wrappers[(20, "Theme")] = self.theme
# Fix #2992 by removing the top-level appearance prop
self.theme.appearance = None
for route in self.unevaluated_pages:
console.debug(f"Evaluating page: {route}")
@ -1007,6 +1005,9 @@ class App(MiddlewareMixin, LifespanMixin):
compile_results.append(
compiler.compile_contexts(self.state, self.theme),
)
if self.theme is not None:
# Fix #2992 by removing the top-level appearance prop
self.theme.appearance = None
progress.advance(task)
# Compile the app root.