Banner components that return Fragment inherit from Fragment

This commit is contained in:
Masen Furer 2025-01-22 15:53:02 -08:00
parent 6a50b3a29e
commit 19dd15bd44
No known key found for this signature in database
GPG Key ID: B0008AD22B3B3A95
2 changed files with 8 additions and 10 deletions

View File

@ -4,6 +4,7 @@ from __future__ import annotations
from typing import Optional from typing import Optional
from reflex.components.base.fragment import Fragment
from reflex.components.component import Component from reflex.components.component import Component
from reflex.components.core.cond import cond from reflex.components.core.cond import cond
from reflex.components.el.elements.typography import Div from reflex.components.el.elements.typography import Div
@ -162,7 +163,7 @@ class ConnectionToaster(Toaster):
return super().create(*children, **props) return super().create(*children, **props)
class ConnectionBanner(Component): class ConnectionBanner(Fragment):
"""A connection banner component.""" """A connection banner component."""
@classmethod @classmethod
@ -175,8 +176,6 @@ class ConnectionBanner(Component):
Returns: Returns:
The connection banner component. The connection banner component.
""" """
from reflex.components.base.fragment import Fragment
if not comp: if not comp:
comp = Flex.create( comp = Flex.create(
Text.create( Text.create(
@ -191,10 +190,10 @@ class ConnectionBanner(Component):
position="fixed", position="fixed",
) )
return Fragment.create(cond(has_connection_errors, comp)) return super().create(cond(has_connection_errors, comp))
class ConnectionModal(Component): class ConnectionModal(Fragment):
"""A connection status modal window.""" """A connection status modal window."""
@classmethod @classmethod
@ -207,11 +206,9 @@ class ConnectionModal(Component):
Returns: Returns:
The connection banner component. The connection banner component.
""" """
from reflex.components.base.fragment import Fragment
if not comp: if not comp:
comp = Text.create(*default_connection_error()) comp = Text.create(*default_connection_error())
return Fragment.create( return super().create(
cond( cond(
has_too_many_connection_errors, has_too_many_connection_errors,
DialogRoot.create( DialogRoot.create(

View File

@ -5,6 +5,7 @@
# ------------------------------------------------------ # ------------------------------------------------------
from typing import Any, Dict, Literal, Optional, Union, overload from typing import Any, Dict, Literal, Optional, Union, overload
from reflex.components.base.fragment import Fragment
from reflex.components.component import Component from reflex.components.component import Component
from reflex.components.el.elements.typography import Div from reflex.components.el.elements.typography import Div
from reflex.components.lucide.icon import Icon from reflex.components.lucide.icon import Icon
@ -137,7 +138,7 @@ class ConnectionToaster(Toaster):
""" """
... ...
class ConnectionBanner(Component): class ConnectionBanner(Fragment):
@overload @overload
@classmethod @classmethod
def create( # type: ignore def create( # type: ignore
@ -176,7 +177,7 @@ class ConnectionBanner(Component):
""" """
... ...
class ConnectionModal(Component): class ConnectionModal(Fragment):
@overload @overload
@classmethod @classmethod
def create( # type: ignore def create( # type: ignore