From 19dd15bd4494b6da9008eaa3a1eb0cafcccd7fc1 Mon Sep 17 00:00:00 2001
From: Masen Furer <m_github@0x26.net>
Date: Wed, 22 Jan 2025 15:53:02 -0800
Subject: [PATCH] Banner components that return Fragment inherit from Fragment

---
 reflex/components/core/banner.py  | 13 +++++--------
 reflex/components/core/banner.pyi |  5 +++--
 2 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/reflex/components/core/banner.py b/reflex/components/core/banner.py
index aa75bb2c7..815510e8b 100644
--- a/reflex/components/core/banner.py
+++ b/reflex/components/core/banner.py
@@ -4,6 +4,7 @@ from __future__ import annotations
 
 from typing import Optional
 
+from reflex.components.base.fragment import Fragment
 from reflex.components.component import Component
 from reflex.components.core.cond import cond
 from reflex.components.el.elements.typography import Div
@@ -162,7 +163,7 @@ class ConnectionToaster(Toaster):
         return super().create(*children, **props)
 
 
-class ConnectionBanner(Component):
+class ConnectionBanner(Fragment):
     """A connection banner component."""
 
     @classmethod
@@ -175,8 +176,6 @@ class ConnectionBanner(Component):
         Returns:
             The connection banner component.
         """
-        from reflex.components.base.fragment import Fragment
-
         if not comp:
             comp = Flex.create(
                 Text.create(
@@ -191,10 +190,10 @@ class ConnectionBanner(Component):
                 position="fixed",
             )
 
-        return Fragment.create(cond(has_connection_errors, comp))
+        return super().create(cond(has_connection_errors, comp))
 
 
-class ConnectionModal(Component):
+class ConnectionModal(Fragment):
     """A connection status modal window."""
 
     @classmethod
@@ -207,11 +206,9 @@ class ConnectionModal(Component):
         Returns:
             The connection banner component.
         """
-        from reflex.components.base.fragment import Fragment
-
         if not comp:
             comp = Text.create(*default_connection_error())
-        return Fragment.create(
+        return super().create(
             cond(
                 has_too_many_connection_errors,
                 DialogRoot.create(
diff --git a/reflex/components/core/banner.pyi b/reflex/components/core/banner.pyi
index f44ee7992..0f10e0df1 100644
--- a/reflex/components/core/banner.pyi
+++ b/reflex/components/core/banner.pyi
@@ -5,6 +5,7 @@
 # ------------------------------------------------------
 from typing import Any, Dict, Literal, Optional, Union, overload
 
+from reflex.components.base.fragment import Fragment
 from reflex.components.component import Component
 from reflex.components.el.elements.typography import Div
 from reflex.components.lucide.icon import Icon
@@ -137,7 +138,7 @@ class ConnectionToaster(Toaster):
         """
         ...
 
-class ConnectionBanner(Component):
+class ConnectionBanner(Fragment):
     @overload
     @classmethod
     def create(  # type: ignore
@@ -176,7 +177,7 @@ class ConnectionBanner(Component):
         """
         ...
 
-class ConnectionModal(Component):
+class ConnectionModal(Fragment):
     @overload
     @classmethod
     def create(  # type: ignore