Github/temporal
1
0
Fork 0
mirror of https://github.com/temporalio/temporal.git synced 2026-08-30 18:41:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

gate commit routing first to async mode

Browse Source
This commit is contained in:
Shivam Saraf
2026-06-08 11:19:41 -04:00
parent 9d979d01fb
commit 68698ec0cc
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
service/worker/workerdeployment/workflow.go
View File

@@ -1033,7 +1033,8 @@ func (d *WorkflowRunner) setRamp(
// tell previous ramping version, if present, that it's no longer ramping
if prevRampingVersion != "" && prevRampingVersion != newRampingVersion {
if workflow.GetVersion(ctx, "commit-routing-first", workflow.DefaultVersion, 0) >= 0 {
commitRoutingFirst := workflow.GetVersion(ctx, "commit-routing-first", workflow.DefaultVersion, 0) >= 0
if asyncMode && commitRoutingFirst {
// Commit routing config before demoting prev ramp to avoid partial state on failure.
d.State.RoutingConfig = pendingRoutingConfig
// Signal the prev ramp version workflow to demote. Unversioned ramp has no version
@@ -1415,7 +1416,8 @@ func (d *WorkflowRunner) handleSetCurrent(ctx workflow.Context, args *deployment
// do is tell the previous current version that it is not current. Then, the task queues in the
// previous current version will have no current version and will become unversioned implicitly.
if workflow.GetVersion(ctx, "commit-routing-first", workflow.DefaultVersion, 0) >= 0 {
commitRoutingFirst := workflow.GetVersion(ctx, "commit-routing-first", workflow.DefaultVersion, 0) >= 0
if asyncMode && commitRoutingFirst {
// Commit routing config before demoting old version to avoid partial state on step 2 failure.
d.State.RoutingConfig = pendingRoutingConfig