From 90f2672bc01535915366ede9a23a3ea2776e2ee5 Mon Sep 17 00:00:00 2001 From: Alek Petuskey Date: Wed, 25 Jan 2023 14:58:59 -0800 Subject: [PATCH] Added Testing to Contributing Guide (#343) --- CONTRIBUTING.md | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 74827078f..cf7c1dadc 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -63,6 +63,17 @@ poetry run pc run All the changes you make to the repository will be reflected in your running app. * We have the examples folder in the .gitignore, so your changes in pynecone/examples won't be reflected in your commit. +## 🧪 Testing and QA + +Any feature or significant change added should be accompanied with unit tests. + +Within the 'test' directory of Pynecone you can add to a test file already there or create a new test python file if it doesn't fit into the existing layout. + +What to unit test? +- Any feature or significant change that has been added. +- Any edge cases or potential problem areas. + -Any interactions between different parts of the code. + ## ✅ Making a PR @@ -85,4 +96,3 @@ Finally run `black` to format your code. poetry run black pynecone ``` That's it you can now submit your pr. Thanks for contributing to Pynecone! -