delete unused function, add cleanup fixture for test_is_prod_mode

This commit is contained in:
Benedikt Bartscher 2024-11-06 23:58:01 +01:00
parent 46fefcf58c
commit f94328f74f
No known key found for this signature in database
3 changed files with 19 additions and 27 deletions

View File

@ -148,28 +148,6 @@ class DBConfig(Base):
return f"{self.engine}://{path}/{self.database}"
def get_default_value_for_field(field: dataclasses.Field) -> Any:
"""Get the default value for a field.
Args:
field: The field.
Returns:
The default value.
Raises:
ValueError: If no default value is found.
"""
if field.default != dataclasses.MISSING:
return field.default
elif field.default_factory != dataclasses.MISSING:
return field.default_factory()
else:
raise ValueError(
f"Missing value for environment variable {field.name} and no default value found"
)
# TODO: Change all interpret_.* signatures to value: str, field: dataclasses.Field once we migrate rx.Config to dataclasses
def interpret_boolean_env(value: str, field_name: str) -> bool:
"""Interpret a boolean environment variable value.
@ -595,9 +573,8 @@ class EnvironmentVariables:
# Whether to minify state names. Default to true in prod mode and false otherwise.
REFLEX_MINIFY_STATES: EnvVar[Optional[bool]] = env_var(
default_factory=lambda: (
EnvironmentVariables.REFLEX_ENV_MODE.get() == constants.Env.PROD
)
default_factory=lambda: EnvironmentVariables.REFLEX_ENV_MODE.get()
== constants.Env.PROD
)

View File

@ -304,6 +304,7 @@ def run(
raise typer.Exit(1)
EnvironmentVariables.REFLEX_BACKEND_ONLY.set(backend)
EnvironmentVariables.REFLEX_FRONTEND_ONLY.set(frontend)
EnvironmentVariables.REFLEX_ENV_MODE.set(env)
_run(env, frontend, backend, frontend_port, backend_port, backend_host, loglevel)

View File

@ -596,8 +596,22 @@ def test_style_prop_with_event_handler_value(callable):
)
def test_is_prod_mode() -> None:
"""Test that the prod mode is correctly determined."""
@pytest.fixture
def cleanup_reflex_env_mode():
"""Cleanup the reflex env mode.
Yields: None
"""
yield
EnvironmentVariables.REFLEX_ENV_MODE.set(None)
def test_is_prod_mode(cleanup_reflex_env_mode: None) -> None:
"""Test that the prod mode is correctly determined.
Args:
cleanup_reflex_env_mode: Fixture to cleanup the reflex env mode.
"""
EnvironmentVariables.REFLEX_ENV_MODE.set(constants.Env.PROD)
assert utils_exec.is_prod_mode()
EnvironmentVariables.REFLEX_ENV_MODE.set(None)