Redact sensitive env vars instead of hiding them
This commit is contained in:
parent
e04dff8154
commit
ed0ae46c37
@ -572,7 +572,7 @@ environment = EnvironmentVariables()
|
|||||||
|
|
||||||
|
|
||||||
# These vars are not logged because they may contain sensitive information.
|
# These vars are not logged because they may contain sensitive information.
|
||||||
_sensitive_env_vars = {"DB_URL", "ASYNC_DB_URL"}
|
_sensitive_env_vars = {"DB_URL", "ASYNC_DB_URL", "REDIS_URL"}
|
||||||
|
|
||||||
|
|
||||||
class Config(Base):
|
class Config(Base):
|
||||||
@ -758,18 +758,20 @@ class Config(Base):
|
|||||||
|
|
||||||
# If the env var is set, override the config value.
|
# If the env var is set, override the config value.
|
||||||
if env_var is not None:
|
if env_var is not None:
|
||||||
if key.upper() not in _sensitive_env_vars:
|
|
||||||
console.info(
|
|
||||||
f"Overriding config value {key} with env var {key.upper()}={env_var}",
|
|
||||||
dedupe=True,
|
|
||||||
)
|
|
||||||
|
|
||||||
# Interpret the value.
|
# Interpret the value.
|
||||||
value = interpret_env_var_value(env_var, field.outer_type_, field.name)
|
value = interpret_env_var_value(env_var, field.outer_type_, field.name)
|
||||||
|
|
||||||
# Set the value.
|
# Set the value.
|
||||||
updated_values[key] = value
|
updated_values[key] = value
|
||||||
|
|
||||||
|
if key.upper() in _sensitive_env_vars:
|
||||||
|
env_var = "***"
|
||||||
|
|
||||||
|
console.info(
|
||||||
|
f"Overriding config value {key} with env var {key.upper()}={env_var}",
|
||||||
|
dedupe=True,
|
||||||
|
)
|
||||||
|
|
||||||
return updated_values
|
return updated_values
|
||||||
|
|
||||||
def get_event_namespace(self) -> str:
|
def get_event_namespace(self) -> str:
|
||||||
|
Loading…
Reference in New Issue
Block a user