CLI will not set auto/stop setting for deployment (#2040)
* do not set autostart/autostop as default on CLI * cli feedback * fix test * clean up last few messages * catch general exception for export and exit
This commit is contained in:
parent
70a6b5f2d3
commit
e9cf822460
@ -19,6 +19,6 @@ class Hosting:
|
|||||||
# The time to sleep between requests to check if for authentication completion. In seconds.
|
# The time to sleep between requests to check if for authentication completion. In seconds.
|
||||||
WEB_AUTH_SLEEP_DURATION = 5
|
WEB_AUTH_SLEEP_DURATION = 5
|
||||||
# The time to wait for the backend to come up after user initiates deployment. In seconds.
|
# The time to wait for the backend to come up after user initiates deployment. In seconds.
|
||||||
BACKEND_POLL_RETRIES = 30
|
BACKEND_POLL_RETRIES = 45
|
||||||
# The time to wait for the frontend to come up after user initiates deployment. In seconds.
|
# The time to wait for the frontend to come up after user initiates deployment. In seconds.
|
||||||
FRONTEND_POLL_RETRIES = 30
|
FRONTEND_POLL_RETRIES = 30
|
||||||
|
@ -452,12 +452,12 @@ def deploy(
|
|||||||
None, help="The amount of memory to allocate.", hidden=True
|
None, help="The amount of memory to allocate.", hidden=True
|
||||||
),
|
),
|
||||||
auto_start: Optional[bool] = typer.Option(
|
auto_start: Optional[bool] = typer.Option(
|
||||||
True,
|
None,
|
||||||
help="Whether to auto start the instance.",
|
help="Whether to auto start the instance.",
|
||||||
hidden=True,
|
hidden=True,
|
||||||
),
|
),
|
||||||
auto_stop: Optional[bool] = typer.Option(
|
auto_stop: Optional[bool] = typer.Option(
|
||||||
True,
|
None,
|
||||||
help="Whether to auto stop the instance.",
|
help="Whether to auto stop the instance.",
|
||||||
hidden=True,
|
hidden=True,
|
||||||
),
|
),
|
||||||
@ -550,7 +550,8 @@ def deploy(
|
|||||||
console.debug(f"{enabled_regions=}")
|
console.debug(f"{enabled_regions=}")
|
||||||
while True:
|
while True:
|
||||||
region_input = console.ask(
|
region_input = console.ask(
|
||||||
"Region to deploy to", default=regions[0] if regions else "sjc"
|
"Region to deploy to. Enter to use default.",
|
||||||
|
default=regions[0] if regions else "sjc",
|
||||||
)
|
)
|
||||||
|
|
||||||
if enabled_regions is None or region_input in enabled_regions:
|
if enabled_regions is None or region_input in enabled_regions:
|
||||||
@ -595,6 +596,11 @@ def deploy(
|
|||||||
if os.path.exists(tmp_dir):
|
if os.path.exists(tmp_dir):
|
||||||
shutil.rmtree(tmp_dir)
|
shutil.rmtree(tmp_dir)
|
||||||
raise typer.Exit(1) from ie
|
raise typer.Exit(1) from ie
|
||||||
|
except Exception as ex:
|
||||||
|
console.error(f"Unable to export due to: {ex}")
|
||||||
|
if os.path.exists(tmp_dir):
|
||||||
|
shutil.rmtree(tmp_dir)
|
||||||
|
raise typer.Exit(1) from ex
|
||||||
|
|
||||||
frontend_file_name = constants.ComponentName.FRONTEND.zip()
|
frontend_file_name = constants.ComponentName.FRONTEND.zip()
|
||||||
backend_file_name = constants.ComponentName.BACKEND.zip()
|
backend_file_name = constants.ComponentName.BACKEND.zip()
|
||||||
@ -652,8 +658,6 @@ def deploy(
|
|||||||
time.sleep(1)
|
time.sleep(1)
|
||||||
if not backend_up:
|
if not backend_up:
|
||||||
console.print("Backend unreachable")
|
console.print("Backend unreachable")
|
||||||
else:
|
|
||||||
console.print("Backend is up")
|
|
||||||
|
|
||||||
with console.status("Checking frontend ..."):
|
with console.status("Checking frontend ..."):
|
||||||
for _ in range(constants.Hosting.FRONTEND_POLL_RETRIES):
|
for _ in range(constants.Hosting.FRONTEND_POLL_RETRIES):
|
||||||
@ -662,17 +666,15 @@ def deploy(
|
|||||||
time.sleep(1)
|
time.sleep(1)
|
||||||
if not frontend_up:
|
if not frontend_up:
|
||||||
console.print("frontend is unreachable")
|
console.print("frontend is unreachable")
|
||||||
else:
|
|
||||||
console.print("frontend is up")
|
|
||||||
|
|
||||||
if frontend_up and backend_up:
|
if frontend_up and backend_up:
|
||||||
console.print(
|
console.print(
|
||||||
f"Your site [ {key} ] at {regions} is up: {deploy_response.frontend_url}"
|
f"Your site [ {key} ] at {regions} is up: {deploy_response.frontend_url}"
|
||||||
)
|
)
|
||||||
return
|
return
|
||||||
console.warn(
|
console.warn(f"Your deployment is taking time.")
|
||||||
f"Your deployment is taking unusually long. Check back later on its status: `reflex deployments status {key}`"
|
console.warn(f"Check back later on its status: `reflex deployments status {key}`")
|
||||||
)
|
console.warn(f"For logs: `reflex deployments logs {key}`")
|
||||||
|
|
||||||
|
|
||||||
deployments_cli = typer.Typer()
|
deployments_cli = typer.Typer()
|
||||||
|
@ -972,7 +972,8 @@ def interactive_get_deployment_key_from_user_input(
|
|||||||
|
|
||||||
# If user takes the suggestion, we will use the suggested key and proceed
|
# If user takes the suggestion, we will use the suggested key and proceed
|
||||||
while key_input := console.ask(
|
while key_input := console.ask(
|
||||||
f"Choose a name for your deployed app", default=key_candidate
|
f"Choose a name for your deployed app. Enter to use default.",
|
||||||
|
default=key_candidate,
|
||||||
):
|
):
|
||||||
try:
|
try:
|
||||||
pre_deploy_response = prepare_deploy(
|
pre_deploy_response = prepare_deploy(
|
||||||
|
@ -150,8 +150,8 @@ def test_deploy_non_interactive_success(
|
|||||||
app_prefix=app_prefix,
|
app_prefix=app_prefix,
|
||||||
cpus=None,
|
cpus=None,
|
||||||
memory_mb=None,
|
memory_mb=None,
|
||||||
auto_start=True,
|
auto_start=None,
|
||||||
auto_stop=True,
|
auto_stop=None,
|
||||||
frontend_hostname=None,
|
frontend_hostname=None,
|
||||||
envs=None,
|
envs=None,
|
||||||
with_metrics=None,
|
with_metrics=None,
|
||||||
@ -374,8 +374,8 @@ def test_deploy_interactive(
|
|||||||
app_prefix=app_prefix,
|
app_prefix=app_prefix,
|
||||||
cpus=None,
|
cpus=None,
|
||||||
memory_mb=None,
|
memory_mb=None,
|
||||||
auto_start=True,
|
auto_start=None,
|
||||||
auto_stop=True,
|
auto_stop=None,
|
||||||
frontend_hostname=None,
|
frontend_hostname=None,
|
||||||
envs=None,
|
envs=None,
|
||||||
with_metrics=None,
|
with_metrics=None,
|
||||||
|
Loading…
Reference in New Issue
Block a user