laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use strict equality in generated JS (#750)

Browse Source
This commit is contained in:
jonatan 2023-04-03 00:40:52 +02:00 committed by GitHub
parent 50d480da1f
commit e811a84ed4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pynecone/var.py
View File

@ -373,7 +373,7 @@ class Var(ABC):
Returns: Returns:
A var representing the equality comparison. A var representing the equality comparison.
""" """
return self.compare("==", other) return self.compare("===", other)
def __ne__(self, other: Var) -> Var: def __ne__(self, other: Var) -> Var:
"""Perform an inequality comparison. """Perform an inequality comparison.
@ -384,7 +384,7 @@ class Var(ABC):
Returns: Returns:
A var representing the inequality comparison. A var representing the inequality comparison.
""" """
return self.compare("!=", other) return self.compare("!==", other)
def __gt__(self, other: Var) -> Var: def __gt__(self, other: Var) -> Var:
"""Perform a greater than comparison. """Perform a greater than comparison.

4
tests/test_var.py
View File

@ -167,8 +167,8 @@ def test_basic_operations(TestObj):
Args: Args:
TestObj: The test object. TestObj: The test object.
""" """
assert str(v(1) == v(2)) == "{(1 == 2)}" assert str(v(1) == v(2)) == "{(1 === 2)}"
assert str(v(1) != v(2)) == "{(1 != 2)}" assert str(v(1) != v(2)) == "{(1 !== 2)}"
assert str(v(1) < v(2)) == "{(1 < 2)}" assert str(v(1) < v(2)) == "{(1 < 2)}"
assert str(v(1) <= v(2)) == "{(1 <= 2)}" assert str(v(1) <= v(2)) == "{(1 <= 2)}"
assert str(v(1) > v(2)) == "{(1 > 2)}" assert str(v(1) > v(2)) == "{(1 > 2)}"