laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

add type to check to state setattr

Browse Source
This commit is contained in:
Khaleel Al-Adhami 2024-10-29 16:18:58 -07:00
parent 39952ce70b
commit e1cbce53b5
1 changed files with 15 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
reflex/state.py
View File

@ -91,7 +91,7 @@ from reflex.utils.exceptions import (
) )
from reflex.utils.exec import is_testing_env from reflex.utils.exec import is_testing_env
from reflex.utils.serializers import serializer from reflex.utils.serializers import serializer
from reflex.utils.types import get_origin, override from reflex.utils.types import _isinstance, get_origin, override
from reflex.vars import VarData from reflex.vars import VarData
if TYPE_CHECKING: if TYPE_CHECKING:
@ -636,7 +636,7 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
def computed_var_func(state: Self): def computed_var_func(state: Self):
result = f(state) result = f(state)
if not isinstance(result, of_type): if not _isinstance(result, of_type):
console.warn( console.warn(
f"Inline ComputedVar {f} expected type {of_type}, got {type(result)}. " f"Inline ComputedVar {f} expected type {of_type}, got {type(result)}. "
"You can specify expected type with `of_type` argument." "You can specify expected type with `of_type` argument."
@ -1274,6 +1274,19 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
f"All state variables must be declared before they can be set." f"All state variables must be declared before they can be set."
) )
fields = self.get_fields()
if name in fields and not _isinstance(
value, (field_type := fields[name].outer_type_)
):
console.deprecate(
"mismatched-type-assignment",
f"Tried to assign value {value} of type {type(value)} to field {type(self).__name__}.{name} of type {field_type}."
" This might lead to unexpected behavior.",
"0.6.5",
"0.7.0",
)
# Set the attribute. # Set the attribute.
super().__setattr__(name, value) super().__setattr__(name, value)