laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[REF-1902] [REF-1987] Chakra upgrade message (#2624)

Browse Source 
* Show rx.chakra upgrade message _before_ overwriting the version

Ensure that the conditions for showing the rx.chakra upgrade message
are checked before overwriting the version saved in .web/reflex.json.

Check for the absense of a config file to suppress the upgrade message
when init'ing a brand new project.

Check for the existance of `reflex.json` before opening it, since it
might not exist at the point it's checked.

* Update more information link in chakra upgrade message

* Fix long line
This commit is contained in:
Masen Furer 2024-02-15 12:49:53 -08:00 committed by GitHub
parent 45b70a130c
commit d979d99338
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
reflex/reflex.py
View File

@ -84,6 +84,10 @@ def _init(
prerequisites.ensure_reflex_installation_id() prerequisites.ensure_reflex_installation_id()
# When upgrading to 0.4, show migration instructions.
if prerequisites.should_show_rx_chakra_migration_instructions():
prerequisites.show_rx_chakra_migration_instructions()
# Set up the app directory, only if the config doesn't exist. # Set up the app directory, only if the config doesn't exist.
if not os.path.exists(constants.Config.FILE): if not os.path.exists(constants.Config.FILE):
if template is None: if template is None:
@ -100,9 +104,6 @@ def _init(
# Migrate Pynecone projects to Reflex. # Migrate Pynecone projects to Reflex.
prerequisites.migrate_to_reflex() prerequisites.migrate_to_reflex()
if prerequisites.should_show_rx_chakra_migration_instructions():
prerequisites.show_rx_chakra_migration_instructions()
# Initialize the .gitignore. # Initialize the .gitignore.
prerequisites.initialize_gitignore() prerequisites.initialize_gitignore()

15
reflex/utils/prerequisites.py
View File

@ -949,8 +949,15 @@ def should_show_rx_chakra_migration_instructions() -> bool:
if os.getenv("REFLEX_PROMPT_MIGRATE_TO_RX_CHAKRA") == "yes": if os.getenv("REFLEX_PROMPT_MIGRATE_TO_RX_CHAKRA") == "yes":
return True return True
with open(constants.Dirs.REFLEX_JSON, "r") as f: if not Path(constants.Config.FILE).exists():
data = json.load(f) # They are running reflex init for the first time.
return False
existing_init_reflex_version = None
reflex_json = Path(constants.Dirs.REFLEX_JSON)
if reflex_json.exists():
with reflex_json.open("r") as f:
data = json.load(f)
existing_init_reflex_version = data.get("version", None) existing_init_reflex_version = data.get("version", None)
if existing_init_reflex_version is None: if existing_init_reflex_version is None:
@ -975,7 +982,9 @@ def show_rx_chakra_migration_instructions():
"[bold]Run `reflex script keep-chakra` to automatically update your app." "[bold]Run `reflex script keep-chakra` to automatically update your app."
) )
console.log("") console.log("")
console.log("For more details, please see https://TODO") # TODO add link to docs console.log(
"For more details, please see https://reflex.dev/blog/2024-02-15-reflex-v0.4.0"
)
def migrate_to_rx_chakra(): def migrate_to_rx_chakra():