laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

simplify logic, store initial values for now

Browse Source
This commit is contained in:
Benedikt Bartscher 2024-12-08 23:08:35 +01:00
parent 1a3a230929
commit cc1b1a7818
No known key found for this signature in database
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
reflex/vars/base.py
View File

@ -2204,21 +2204,14 @@ class ComputedVar(Var[RETURN_TYPE]):
has_cache = hasattr(instance, self._cache_attr) has_cache = hasattr(instance, self._cache_attr)
if self.already_computed(instance): if self.already_computed(instance) and has_cache:
if has_cache: return getattr(instance, self._cache_attr)
return getattr(instance, self._cache_attr)
else:
assert not isinstance(self._initial_value, types.Unset)
return self._initial_value
cache_value = getattr(instance, self._cache_attr, None) cache_value = getattr(instance, self._cache_attr, None)
instance._ready_computed_vars.add(self._js_expr) instance._ready_computed_vars.add(self._js_expr)
setattr(instance, self._last_updated_attr, datetime.datetime.now()) setattr(instance, self._last_updated_attr, datetime.datetime.now())
new_value = self.fget(instance) new_value = self.fget(instance)
# NOTE: does not store initial_value in redis to save space/time if cache_value != new_value:
if (has_cache and cache_value != new_value) or (
not has_cache and new_value != self._initial_value
):
instance._changed_computed_vars.add(self._js_expr) instance._changed_computed_vars.add(self._js_expr)
instance._was_touched = True instance._was_touched = True
setattr(instance, self._cache_attr, new_value) setattr(instance, self._cache_attr, new_value)