From cbe5a8f9d8d782b34d7bc25f6d9644c144487eaa Mon Sep 17 00:00:00 2001 From: Elijah Date: Thu, 31 Oct 2024 16:38:54 +0000 Subject: [PATCH] the tests are not valid + pyright fix --- reflex/components/markdown/markdown.py | 2 +- .../units/components/datadisplay/test_code.py | 19 ------------------- 2 files changed, 1 insertion(+), 20 deletions(-) diff --git a/reflex/components/markdown/markdown.py b/reflex/components/markdown/markdown.py index 73bee1de7..00e782399 100644 --- a/reflex/components/markdown/markdown.py +++ b/reflex/components/markdown/markdown.py @@ -381,7 +381,7 @@ class Markdown(Component): component.component_fn(*component.get_prop_vars()) ) ) - else: + elif isinstance(component, Component): for child in component.children: custom_code_list.extend( self._get_map_fn_custom_code_from_children(child) diff --git a/tests/units/components/datadisplay/test_code.py b/tests/units/components/datadisplay/test_code.py index 809c68fe5..6b7168756 100644 --- a/tests/units/components/datadisplay/test_code.py +++ b/tests/units/components/datadisplay/test_code.py @@ -11,22 +11,3 @@ def test_code_light_dark_theme(theme, expected): code_block = CodeBlock.create(theme=theme) assert code_block.theme._js_expr == expected # type: ignore - - -def generate_custom_code(language, expected_case): - return f"SyntaxHighlighter.registerLanguage('{language}', {expected_case})" - - -@pytest.mark.parametrize( - "language, expected_case", - [ - ("python", "python"), - ("firestore-security-rules", "firestoreSecurityRules"), - ("typescript", "typescript"), - ], -) -def test_get_custom_code(language, expected_case): - code_block = CodeBlock.create(language=language) - assert code_block._get_custom_code() == generate_custom_code( - language, expected_case - )