From ca4724cec81b348edce91f3dd8193e508c3b543c Mon Sep 17 00:00:00 2001
From: Masen Furer <m_github@0x26.net>
Date: Thu, 31 Aug 2023 14:57:28 -0700
Subject: [PATCH] AppHarness: disable telemetry for test apps (#1733)

---
 reflex/config.py     | 6 +++++-
 reflex/testing.py    | 1 +
 tests/test_config.py | 2 ++
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/reflex/config.py b/reflex/config.py
index a79350935..2ce3cb86c 100644
--- a/reflex/config.py
+++ b/reflex/config.py
@@ -245,7 +245,11 @@ class Config(Base):
 
                 # Convert the env var to the expected type.
                 try:
-                    env_var = field.type_(env_var)
+                    if issubclass(field.type_, bool):
+                        # special handling for bool values
+                        env_var = env_var.lower() in ["true", "1", "yes"]
+                    else:
+                        env_var = field.type_(env_var)
                 except ValueError:
                     console.error(
                         f"Could not convert {key.upper()}={env_var} to type {field.type_}"
diff --git a/reflex/testing.py b/reflex/testing.py
index caea87308..168f33b9d 100644
--- a/reflex/testing.py
+++ b/reflex/testing.py
@@ -141,6 +141,7 @@ class AppHarness:
         )
 
     def _initialize_app(self):
+        os.environ["TELEMETRY_ENABLED"] = ""  # disable telemetry reporting for tests
         self.app_path.mkdir(parents=True, exist_ok=True)
         if self.app_source is not None:
             # get the source from a function or module object
diff --git a/tests/test_config.py b/tests/test_config.py
index da5df7357..57e04aaa5 100644
--- a/tests/test_config.py
+++ b/tests/test_config.py
@@ -54,6 +54,8 @@ def test_deprecated_params(base_config_values, param):
         ("DB_URL", "postgresql://user:pass@localhost:5432/db"),
         ("REDIS_URL", "redis://localhost:6379"),
         ("TIMEOUT", 600),
+        ("TELEMETRY_ENABLED", False),
+        ("TELEMETRY_ENABLED", True),
     ],
 )
 def test_update_from_env(base_config_values, monkeypatch, env_var, value):