From c05da488f95eb651cc5f100f3d32313bde08374d Mon Sep 17 00:00:00 2001 From: Masen Furer Date: Mon, 21 Oct 2024 12:56:56 -0700 Subject: [PATCH] Raise TypeError when `ComputedVar.__init__` gets bad kwargs (#4199) It's easy to mis-spell `rx.var(cached=True)` instead of `rx.var(cache=True)`, and in 0.6.3, this doesn't actual raise an error... the bad value is silently discarded and the var is NOT marked as being cached. --- reflex/vars/base.py | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/reflex/vars/base.py b/reflex/vars/base.py index 14e7251bb..cf02863c3 100644 --- a/reflex/vars/base.py +++ b/reflex/vars/base.py @@ -1557,8 +1557,8 @@ class ComputedVar(Var[RETURN_TYPE]): "return", Any ) - kwargs["_js_expr"] = kwargs.pop("_js_expr", fget.__name__) - kwargs["_var_type"] = kwargs.pop("_var_type", hint) + kwargs.setdefault("_js_expr", fget.__name__) + kwargs.setdefault("_var_type", hint) Var.__init__( self, @@ -1567,6 +1567,9 @@ class ComputedVar(Var[RETURN_TYPE]): _var_data=kwargs.pop("_var_data", None), ) + if kwargs: + raise TypeError(f"Unexpected keyword arguments: {tuple(kwargs)}") + if backend is None: backend = fget.__name__.startswith("_")