Default to None if bun/fnm version is Invalid (#2940)

This commit is contained in:
Elijah Ahianyo 2024-03-27 19:38:56 +00:00 committed by GitHub
parent 94823f1317
commit b34c97d725
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -127,6 +127,11 @@ def get_fnm_version() -> version.Version | None:
return version.parse(result.stdout.split(" ")[1]) # type: ignore
except (FileNotFoundError, TypeError):
return None
except version.InvalidVersion as e:
console.warn(
f"The detected fnm version ({e.args[0]}) is not valid. Defaulting to None."
)
return None
def get_bun_version() -> version.Version | None:
@ -141,6 +146,11 @@ def get_bun_version() -> version.Version | None:
return version.parse(result.stdout) # type: ignore
except FileNotFoundError:
return None
except version.InvalidVersion as e:
console.warn(
f"The detected bun version ({e.args[0]}) is not valid. Defaulting to None."
)
return None
def get_install_package_manager() -> str | None:
@ -854,6 +864,7 @@ def validate_bun():
# This is specific to non-FHS OS
bun_path = get_config().bun_path
if bun_path != constants.Bun.DEFAULT_PATH:
console.info(f"Using custom Bun path: {bun_path}")
bun_version = get_bun_version()
if not bun_version:
console.error(