laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

minor performance improvement for recursive state dirty substates

Browse Source
This commit is contained in:
Benedikt Bartscher 2024-12-14 14:00:09 +01:00
parent 604e96a52d
commit aa4e32dcd2
No known key found for this signature in database
1 changed files with 17 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
reflex/state.py
View File

@ -1976,16 +1976,24 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
return fetch_substates
@classmethod
def _recursive_potentially_dirty_substates(cls) -> set[str]:
def _recursive_potentially_dirty_substates(
cls,
already_selected: Type[BaseState] | None = None,
) -> set[str]:
"""Recursively determine substates which could be affected by dirty vars in this state.
Args:
already_selected: The class of the state that has already been selected and needs no further processing.
Returns:
Set of full state names that may need to be fetched to recalc computed vars.
"""
if already_selected is not None and already_selected == cls:
return set()
fetch_substates = cls._potentially_dirty_substates()
for substate_cls in cls.get_substates():
fetch_substates.update(
substate_cls._recursive_potentially_dirty_substates()
substate_cls._recursive_potentially_dirty_substates(already_selected)
)
return fetch_substates
@ -3376,7 +3384,6 @@ class StateManagerRedis(StateManager):
walk_state_path = walk_state_path.rpartition(".")[0]
state_tokens.add(walk_state_path)
state_tokens.update(self.state._recursive_potentially_dirty_substates())
if get_substates:
state_tokens.update(
{
@ -3384,6 +3391,13 @@ class StateManagerRedis(StateManager):
for substate in state_cls.get_all_substate_classes()
}
)
state_tokens.update(
self.state._recursive_potentially_dirty_substates(
already_selected=state_cls,
)
)
else:
state_tokens.update(self.state._recursive_potentially_dirty_substates())
loaded_states = {}
if parent_state is not None: