laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use version.parse in check_node_version() (#951)

Browse Source
This commit is contained in:
Thomas Brandého 2023-05-06 00:57:29 +02:00 committed by GitHub
parent 0d51f58c9f
commit a24d382eb6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
pynecone/utils/prerequisites.py
View File

@ -21,7 +21,7 @@ from pynecone.config import get_config
from pynecone.utils import console, path_ops from pynecone.utils import console, path_ops
def check_node_version(min_version): def check_node_version(min_version=constants.MIN_NODE_VERSION):
"""Check the version of Node.js. """Check the version of Node.js.
Args: Args:
@ -35,10 +35,10 @@ def check_node_version(min_version):
result = subprocess.run( result = subprocess.run(
["node", "-v"], stdout=subprocess.PIPE, stderr=subprocess.PIPE ["node", "-v"], stdout=subprocess.PIPE, stderr=subprocess.PIPE
) )
# The output will be in the form "vX.Y.Z", so we can split it on the "v" character and take the second part # The output will be in the form "vX.Y.Z", but version.parse() can handle it
version = result.stdout.decode().strip().split("v")[1] current_version = version.parse(result.stdout.decode())
# Compare the version numbers # Compare the version numbers
return version.split(".") >= min_version.split(".") return current_version >= version.parse(min_version)
except Exception: except Exception:
return False return False
@ -73,7 +73,7 @@ def get_package_manager() -> str:
config = get_config() config = get_config()
# Check that the node version is valid. # Check that the node version is valid.
if not check_node_version(constants.MIN_NODE_VERSION): if not check_node_version():
console.print( console.print(
f"[red]Node.js version {constants.MIN_NODE_VERSION} or higher is required to run Pynecone." f"[red]Node.js version {constants.MIN_NODE_VERSION} or higher is required to run Pynecone."
) )