laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

debounce_input should respect child ref (#1717)

Browse Source
This commit is contained in:
Masen Furer 2023-08-30 12:46:55 -07:00 committed by GitHub
parent 9fbc75d84a
commit 99843d98af
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
integration/test_form_submit.py
View File

@ -36,6 +36,11 @@ def FormSubmit():
rx.radio_group(["option1", "option2"], id="radio_input"), rx.radio_group(["option1", "option2"], id="radio_input"),
rx.select(["option1", "option2"], id="select_input"), rx.select(["option1", "option2"], id="select_input"),
rx.text_area(id="text_area_input"), rx.text_area(id="text_area_input"),
rx.input(
id="debounce_input",
debounce_timeout=0,
on_change=rx.console_log,
),
rx.button("Submit", type_="submit"), rx.button("Submit", type_="submit"),
), ),
on_submit=FormState.form_submit, on_submit=FormState.form_submit,
@ -119,6 +124,9 @@ def test_submit(driver, form_submit: AppHarness):
textarea_input = driver.find_element(By.CLASS_NAME, "chakra-textarea") textarea_input = driver.find_element(By.CLASS_NAME, "chakra-textarea")
textarea_input.send_keys("Some", Keys.ENTER, "Text") textarea_input.send_keys("Some", Keys.ENTER, "Text")
debounce_input = driver.find_element(By.ID, "debounce_input")
debounce_input.send_keys("bar baz")
time.sleep(1) time.sleep(1)
submit_input = driver.find_element(By.CLASS_NAME, "chakra-button") submit_input = driver.find_element(By.CLASS_NAME, "chakra-button")
@ -139,3 +147,4 @@ def test_submit(driver, form_submit: AppHarness):
assert backend_state.form_data["radio_input"] == "option2" assert backend_state.form_data["radio_input"] == "option2"
assert backend_state.form_data["select_input"] == "option1" assert backend_state.form_data["select_input"] == "option1"
assert backend_state.form_data["text_area_input"] == "Some\nText" assert backend_state.form_data["text_area_input"] == "Some\nText"
assert backend_state.form_data["debounce_input"] == "bar baz"

6
reflex/components/forms/debounce.py
View File

@ -46,6 +46,7 @@ class DebounceInput(Component):
Raises: Raises:
RuntimeError: unless exactly one child element is provided. RuntimeError: unless exactly one child element is provided.
ValueError: if the child element does not have an on_change handler.
""" """
child, props = _collect_first_child_and_props(self) child, props = _collect_first_child_and_props(self)
if isinstance(child, type(self)) or len(self.children) > 1: if isinstance(child, type(self)) or len(self.children) > 1:
@ -53,6 +54,11 @@ class DebounceInput(Component):
"Provide a single child for DebounceInput, such as rx.input() or " "Provide a single child for DebounceInput, such as rx.input() or "
"rx.text_area()", "rx.text_area()",
) )
if "on_change" not in child.event_triggers:
raise ValueError("DebounceInput child requires an on_change handler")
child_ref = child.get_ref()
if child_ref and not props.get("ref"):
props["input_ref"] = Var.create(child_ref, is_local=False)
self.children = [] self.children = []
tag = super()._render() tag = super()._render()
tag.add_props( tag.add_props(