laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

make download work for state vars (#2092)

Browse Source
This commit is contained in:
Thomas Brandého 2023-11-01 01:08:10 +01:00 committed by GitHub
parent 853a43eaab
commit 96c09b0f6b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
reflex/.templates/web/utils/state.js
View File

@ -171,7 +171,8 @@ export const applyEvent = async (event, socket) => {
const a = document.createElement('a');
a.hidden = true;
a.href = event.payload.url;
a.download = event.payload.filename;
if (event.payload.filename)
a.download = event.payload.filename;
a.click();
a.remove();
return false;

16
reflex/event.py
View File

@ -434,7 +434,7 @@ def set_clipboard(content: str) -> EventSpec:
)
def download(url: str, filename: Optional[str] = None) -> EventSpec:
def download(url: str | Var, filename: Optional[str | Var] = None) -> EventSpec:
"""Download the file at a given path.
Args:
@ -447,12 +447,16 @@ def download(url: str, filename: Optional[str] = None) -> EventSpec:
Returns:
EventSpec: An event to download the associated file.
"""
if not url.startswith("/"):
raise ValueError("The URL argument should start with a /")
if isinstance(url, Var) and filename is None:
filename = ""
# if filename is not provided, infer it from url
if filename is None:
filename = url.rpartition("/")[-1]
if isinstance(url, str):
if not url.startswith("/"):
raise ValueError("The URL argument should start with a /")
# if filename is not provided, infer it from url
if filename is None:
filename = url.rpartition("/")[-1]
return server_side(
"_download",