laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

disable the error and print deprecation warning instead

Browse Source
This commit is contained in:
Khaleel Al-Adhami 2024-10-28 19:11:20 -07:00
parent e9a2dc3717
commit 94c15f45c8
1 changed files with 17 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
reflex/event.py
View File

@ -1061,8 +1061,6 @@ def call_event_handler(
Raises: Raises:
EventHandlerArgMismatch: if number of arguments expected by event_handler doesn't match the spec. EventHandlerArgMismatch: if number of arguments expected by event_handler doesn't match the spec.
EventHandlerArgTypeMismatch: if the annotations of args accepted by event_handler differs from the spec of the event trigger.
TypeError: if a failure occurs while comparing types.
Returns: Returns:
The event spec from calling the event handler. The event spec from calling the event handler.
@ -1129,10 +1127,15 @@ def call_event_handler(
compare_result = typehint_issubclass( compare_result = typehint_issubclass(
args_types_without_vars[i], type_hints_of_provided_callback[arg] args_types_without_vars[i], type_hints_of_provided_callback[arg]
) )
except TypeError as e: except TypeError:
raise TypeError( # TODO: In 0.7.0, remove this block and raise the exception
# raise TypeError(
# f"Could not compare types {args_types_without_vars[i]} and {type_hints_of_provided_callback[arg]} for argument {arg} of {event_handler.fn.__qualname__} provided for {key}."
# ) from e
console.warn(
f"Could not compare types {args_types_without_vars[i]} and {type_hints_of_provided_callback[arg]} for argument {arg} of {event_handler.fn.__qualname__} provided for {key}." f"Could not compare types {args_types_without_vars[i]} and {type_hints_of_provided_callback[arg]} for argument {arg} of {event_handler.fn.__qualname__} provided for {key}."
) from e )
compare_result = False
if compare_result: if compare_result:
continue continue
@ -1140,12 +1143,9 @@ def call_event_handler(
failure = EventHandlerArgTypeMismatch( failure = EventHandlerArgTypeMismatch(
f"Event handler {key} expects {args_types_without_vars[i]} for argument {arg} but got {type_hints_of_provided_callback[arg]} as annotated in {event_handler.fn.__qualname__} instead." f"Event handler {key} expects {args_types_without_vars[i]} for argument {arg} but got {type_hints_of_provided_callback[arg]} as annotated in {event_handler.fn.__qualname__} instead."
) )
if len(event_spec_return_types) == 1: failures.append(failure)
raise failure failed_type_check = True
else: break
failures.append(failure)
failed_type_check = True
break
if not failed_type_check: if not failed_type_check:
if event_spec_index: if event_spec_index:
@ -1172,7 +1172,12 @@ def call_event_handler(
return event_handler(*parsed_args) return event_handler(*parsed_args)
if failures: if failures:
raise EventHandlerArgTypeMismatch("\n".join([str(f) for f in failures])) console.deprecate(
"Mismatched event handler argument types",
"\n".join([str(f) for f in failures]),
"0.6.5",
"0.7.0",
)
return event_handler(*parsed_args) # type: ignore return event_handler(*parsed_args) # type: ignore