only do literals as component vars

This commit is contained in:
Khaleel Al-Adhami 2024-10-25 13:43:53 -07:00
parent 0cede0759f
commit 923e60f159
2 changed files with 21 additions and 18 deletions

View File

@ -2,13 +2,13 @@ name: integration-tests
on: on:
push: push:
branches: ["main"] branches: ['main']
paths-ignore: paths-ignore:
- "**/*.md" - '**/*.md'
pull_request: pull_request:
branches: ["main"] branches: ['main']
paths-ignore: paths-ignore:
- "**/*.md" - '**/*.md'
concurrency: concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.id }} group: ${{ github.workflow }}-${{ github.event.pull_request.id }}
@ -27,9 +27,9 @@ env:
# TODO: can we fix windows encoding natively within reflex? Bug above can hit real users too (less common, but possible) # TODO: can we fix windows encoding natively within reflex? Bug above can hit real users too (less common, but possible)
# - Catch encoding errors when printing logs # - Catch encoding errors when printing logs
# - Best effort print lines that contain illegal chars (map to some default char, etc.) # - Best effort print lines that contain illegal chars (map to some default char, etc.)
PYTHONIOENCODING: "utf8" PYTHONIOENCODING: 'utf8'
TELEMETRY_ENABLED: false TELEMETRY_ENABLED: false
NODE_OPTIONS: "--max_old_space_size=8192" NODE_OPTIONS: '--max_old_space_size=8192'
PR_TITLE: ${{ github.event.pull_request.title }} PR_TITLE: ${{ github.event.pull_request.title }}
jobs: jobs:
@ -43,17 +43,17 @@ jobs:
matrix: matrix:
# Show OS combos first in GUI # Show OS combos first in GUI
os: [ubuntu-latest, windows-latest] os: [ubuntu-latest, windows-latest]
python-version: ["3.9.18", "3.10.13", "3.11.5", "3.12.0"] python-version: ['3.9.18', '3.10.13', '3.11.5', '3.12.0']
exclude: exclude:
- os: windows-latest - os: windows-latest
python-version: "3.10.13" python-version: '3.10.13'
- os: windows-latest - os: windows-latest
python-version: "3.9.18" python-version: '3.9.18'
include: include:
- os: windows-latest - os: windows-latest
python-version: "3.10.11" python-version: '3.10.11'
- os: windows-latest - os: windows-latest
python-version: "3.9.13" python-version: '3.9.13'
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
steps: steps:
@ -115,17 +115,18 @@ jobs:
--branch-name "${{ github.head_ref || github.ref_name }}" --pr-id "${{ github.event.pull_request.id }}" --branch-name "${{ github.head_ref || github.ref_name }}" --pr-id "${{ github.event.pull_request.id }}"
--app-name "counter" --app-name "counter"
reflex-web: reflex-web:
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
# Show OS combos first in GUI # Show OS combos first in GUI
os: [ubuntu-latest, windows-latest] os: [ubuntu-latest, windows-latest]
python-version: ["3.10.11", "3.11.4"] python-version: ['3.10.11', '3.11.4']
env: env:
REFLEX_WEB_WINDOWS_OVERRIDE: "1" REFLEX_WEB_WINDOWS_OVERRIDE: '1'
REFLEX_WEB_WINDOWS_MAX_ROUTES: "25"
runs-on: ${{ matrix.os }} runs-on: ${{ matrix.os }}
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
@ -161,13 +162,13 @@ jobs:
--python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}" --python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}"
--pr-id "${{ github.event.pull_request.id }}" --branch-name "${{ github.head_ref || github.ref_name }}" --pr-id "${{ github.event.pull_request.id }}" --branch-name "${{ github.head_ref || github.ref_name }}"
--app-name "reflex-web" --path ./reflex-web/.web --app-name "reflex-web" --path ./reflex-web/.web
reflex-web-macos: reflex-web-macos:
if: github.event_name == 'push' && github.ref == 'refs/heads/main' if: github.event_name == 'push' && github.ref == 'refs/heads/main'
strategy: strategy:
fail-fast: false fail-fast: false
matrix: matrix:
python-version: ["3.11.5", "3.12.0"] python-version: ['3.11.5', '3.12.0']
runs-on: macos-12 runs-on: macos-12
steps: steps:
- uses: actions/checkout@v4 - uses: actions/checkout@v4
@ -201,3 +202,4 @@ jobs:
--python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}" --python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}"
--pr-id "${{ github.event.pull_request.id }}" --branch-name "${{ github.head_ref || github.ref_name }}" --pr-id "${{ github.event.pull_request.id }}" --branch-name "${{ github.head_ref || github.ref_name }}"
--app-name "reflex-web" --path ./reflex-web/.web --app-name "reflex-web" --path ./reflex-web/.web

View File

@ -165,7 +165,7 @@ class PackageJson(SimpleNamespace):
class Commands(SimpleNamespace): class Commands(SimpleNamespace):
"""The commands to define in package.json.""" """The commands to define in package.json."""
DEV = "next dev --turbo" DEV = "next dev"
EXPORT = "next build" EXPORT = "next build"
EXPORT_SITEMAP = "next build && next-sitemap" EXPORT_SITEMAP = "next build && next-sitemap"
PROD = "next start" PROD = "next start"
@ -173,10 +173,11 @@ class PackageJson(SimpleNamespace):
PATH = "package.json" PATH = "package.json"
DEPENDENCIES = { DEPENDENCIES = {
"@babel/standalone": "7.25.8",
"@emotion/react": "11.13.3", "@emotion/react": "11.13.3",
"axios": "1.7.7", "axios": "1.7.7",
"json5": "2.2.3", "json5": "2.2.3",
"next": "15.0.1", "next": "14.2.15",
"next-sitemap": "4.2.3", "next-sitemap": "4.2.3",
"next-themes": "0.3.0", "next-themes": "0.3.0",
"react": "18.3.1", "react": "18.3.1",