From 8f07082eba6f3fbc59a0a6f0f4f2931fbaabe223 Mon Sep 17 00:00:00 2001 From: Masen Furer Date: Mon, 28 Oct 2024 16:59:26 -0700 Subject: [PATCH] Handle props annotated as list/dict of EventHandler (#4257) These props are NOT event triggers themselves, but rather they are props that expect a list or dict of event handlers. Additional fix for calling an `@rx.event` decorated event handler with no arguments. --- reflex/components/component.py | 2 +- reflex/event.py | 5 +++++ 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/reflex/components/component.py b/reflex/components/component.py index 9fea2f05b..5c6234749 100644 --- a/reflex/components/component.py +++ b/reflex/components/component.py @@ -645,7 +645,7 @@ class Component(BaseComponent, ABC): # Look for component specific triggers, # e.g. variable declared as EventHandler types. for field in self.get_fields().values(): - if types._issubclass(field.type_, EventHandler): + if types._issubclass(field.outer_type_, EventHandler): args_spec = None annotation = field.annotation if (metadata := getattr(annotation, "__metadata__", None)) is not None: diff --git a/reflex/event.py b/reflex/event.py index 8b75fc01f..86620e65d 100644 --- a/reflex/event.py +++ b/reflex/event.py @@ -1489,6 +1489,11 @@ if sys.version_info >= (3, 10): """ return self + @overload + def __call__( + self: EventCallback[Q, T], + ) -> EventCallback[Q, T]: ... + @overload def __call__( self: EventCallback[Concatenate[V, Q], T], value: V | Var[V]