From 8ec3cf615725109904b67cdcb1d40e8d7f226a45 Mon Sep 17 00:00:00 2001 From: Khaleel Al-Adhami Date: Thu, 10 Oct 2024 12:18:18 -0700 Subject: [PATCH] remove dictify from state dict (#4141) --- reflex/state.py | 7 +------ tests/units/test_state.py | 6 +++--- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/reflex/state.py b/reflex/state.py index 0941dfe07..f488602fa 100644 --- a/reflex/state.py +++ b/reflex/state.py @@ -1879,13 +1879,8 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow): self.dirty_vars.update(self._always_dirty_computed_vars) self._mark_dirty() - def dictify(value: Any): - if dataclasses.is_dataclass(value) and not isinstance(value, type): - return dataclasses.asdict(value) - return value - base_vars = { - prop_name: dictify(self.get_value(getattr(self, prop_name))) + prop_name: self.get_value(getattr(self, prop_name)) for prop_name in self.base_vars } if initial and include_computed: diff --git a/tests/units/test_state.py b/tests/units/test_state.py index a890c2aa4..6246618f6 100644 --- a/tests/units/test_state.py +++ b/tests/units/test_state.py @@ -1290,19 +1290,19 @@ def test_computed_var_depends_on_parent_non_cached(): assert ps.dirty_vars == set() assert cs.dirty_vars == set() - dict1 = ps.dict() + dict1 = json.loads(json_dumps(ps.dict())) assert dict1[ps.get_full_name()] == { "no_cache_v": 1, "router": formatted_router, } assert dict1[cs.get_full_name()] == {"dep_v": 2} - dict2 = ps.dict() + dict2 = json.loads(json_dumps(ps.dict())) assert dict2[ps.get_full_name()] == { "no_cache_v": 3, "router": formatted_router, } assert dict2[cs.get_full_name()] == {"dep_v": 4} - dict3 = ps.dict() + dict3 = json.loads(json_dumps(ps.dict())) assert dict3[ps.get_full_name()] == { "no_cache_v": 5, "router": formatted_router,