From 8b7d613ed779eea0341305072a7bc095832c6e02 Mon Sep 17 00:00:00 2001
From: Lendemor <thomas.brandeho@gmail.com>
Date: Tue, 5 Nov 2024 15:50:26 +0100
Subject: [PATCH] stop ignoring some lint rules that pass ruff check

---
 pyproject.toml                                |  2 +-
 reflex/components/component.py                |  1 -
 .../datadisplay/shiki_code_block.py           |  1 -
 reflex/utils/console.py                       |  1 -
 tests/integration/test_server_side_event.py   |  1 -
 .../tests_playwright/test_router_data.py      | 44 +++++++++++++++++++
 tests/units/components/core/test_debounce.py  |  1 -
 tests/units/utils/test_serializers.py         |  3 --
 8 files changed, 45 insertions(+), 9 deletions(-)
 create mode 100644 tests/integration/tests_playwright/test_router_data.py

diff --git a/pyproject.toml b/pyproject.toml
index a3e3a17f6..c70ec05ee 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -92,7 +92,7 @@ build-backend = "poetry.core.masonry.api"
 [tool.ruff]
 target-version = "py39"
 lint.select = ["B", "D", "E", "F", "I", "SIM", "W"]
-lint.ignore = ["B008", "D203", "D205", "D213", "D401", "D406", "D407", "E501", "F403", "F405", "F541", "SIM115"]
+lint.ignore = ["B008", "D205", "E501", "F403", "F541", "SIM115"]
 lint.pydocstyle.convention = "google"
 
 [tool.ruff.lint.per-file-ignores]
diff --git a/reflex/components/component.py b/reflex/components/component.py
index 85db3906d..14dacb071 100644
--- a/reflex/components/component.py
+++ b/reflex/components/component.py
@@ -156,7 +156,6 @@ class ComponentNamespace(SimpleNamespace):
     def __hash__(self) -> int:
         """Get the hash of the namespace.
 
-
         Returns:
             The hash of the namespace.
         """
diff --git a/reflex/components/datadisplay/shiki_code_block.py b/reflex/components/datadisplay/shiki_code_block.py
index 07f09c6f6..580d4af78 100644
--- a/reflex/components/datadisplay/shiki_code_block.py
+++ b/reflex/components/datadisplay/shiki_code_block.py
@@ -26,7 +26,6 @@ from reflex.vars.sequence import StringVar, string_replace_operation
 def copy_script() -> Any:
     """Copy script for the code block and modify the child SVG element.
 
-
     Returns:
         Any: The result of calling the script.
     """
diff --git a/reflex/utils/console.py b/reflex/utils/console.py
index 20c699e20..04e590910 100644
--- a/reflex/utils/console.py
+++ b/reflex/utils/console.py
@@ -191,7 +191,6 @@ def ask(
 def progress():
     """Create a new progress bar.
 
-
     Returns:
         A new progress bar.
     """
diff --git a/tests/integration/test_server_side_event.py b/tests/integration/test_server_side_event.py
index cacf6e1c5..7fd592d10 100644
--- a/tests/integration/test_server_side_event.py
+++ b/tests/integration/test_server_side_event.py
@@ -102,7 +102,6 @@ def server_side_event(tmp_path_factory) -> Generator[AppHarness, None, None]:
 def driver(server_side_event: AppHarness):
     """Get an instance of the browser open to the server_side_event app.
 
-
     Args:
         server_side_event: harness for ServerSideEvent app
 
diff --git a/tests/integration/tests_playwright/test_router_data.py b/tests/integration/tests_playwright/test_router_data.py
new file mode 100644
index 000000000..90178f177
--- /dev/null
+++ b/tests/integration/tests_playwright/test_router_data.py
@@ -0,0 +1,44 @@
+import time
+from typing import Generator
+
+import pytest
+from playwright.sync_api import Page
+
+from reflex.testing import AppHarness
+
+
+def RouterDataApp():
+    """App using router data."""
+    import reflex as rx
+
+    app = rx.App(state=rx.State)
+
+    @app.add_page
+    def index():
+        return rx.text(rx.State.router.session.client_token)
+
+
+@pytest.fixture()
+def router_app(tmp_path_factory) -> Generator[AppHarness, None, None]:
+    """Start Table app at tmp_path via AppHarness.
+
+    Args:
+        tmp_path_factory: pytest tmp_path_factory fixture
+
+    Yields:
+        running AppHarness instance
+
+    """
+    with AppHarness.create(
+        root=tmp_path_factory.mktemp("table"),
+        app_source=RouterDataApp,  # type: ignore
+    ) as harness:
+        assert harness.app_instance is not None, "app is not running"
+        yield harness
+
+
+def test_router_data(router_app: AppHarness, page: Page):
+    assert router_app.frontend_url is not None
+
+    page.goto(router_app.frontend_url)
+    time.sleep(5)
diff --git a/tests/units/components/core/test_debounce.py b/tests/units/components/core/test_debounce.py
index 7856ee090..2fad9c925 100644
--- a/tests/units/components/core/test_debounce.py
+++ b/tests/units/components/core/test_debounce.py
@@ -41,7 +41,6 @@ class S(BaseState):
     def on_change(self, v: str):
         """Dummy on_change handler.
 
-
         Args:
             v: The changed value.
         """
diff --git a/tests/units/utils/test_serializers.py b/tests/units/utils/test_serializers.py
index 8050470c6..355f40d3f 100644
--- a/tests/units/utils/test_serializers.py
+++ b/tests/units/utils/test_serializers.py
@@ -20,7 +20,6 @@ from reflex.vars.base import LiteralVar
 def test_has_serializer(type_: Type, expected: bool):
     """Test that has_serializer returns the correct value.
 
-
     Args:
         type_: The type to check.
         expected: The expected result.
@@ -41,7 +40,6 @@ def test_has_serializer(type_: Type, expected: bool):
 def test_get_serializer(type_: Type, expected: serializers.Serializer):
     """Test that get_serializer returns the correct value.
 
-
     Args:
         type_: The type to check.
         expected: The expected result.
@@ -195,7 +193,6 @@ class BaseSubclass(Base):
 def test_serialize(value: Any, expected: str):
     """Test that serialize returns the correct value.
 
-
     Args:
         value: The value to serialize.
         expected: The expected result.