laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

use is true for bool var (#3973)

Browse Source
This commit is contained in:
Khaleel Al-Adhami 2024-09-23 16:36:58 -07:00 committed by Masen Furer
parent dfad519bae
commit 73f3454b43
No known key found for this signature in database
GPG Key ID: 2AE2BD5531FF94F4
2 changed files with 15 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
reflex/vars/sequence.py
View File

@ -194,14 +194,6 @@ class StringVar(Var[str]):
""" """
return string_strip_operation(self) return string_strip_operation(self)
def bool(self):
"""Boolean conversion.
Returns:
The boolean value of the string.
"""
return self.length() != 0
def reversed(self) -> StringVar: def reversed(self) -> StringVar:
"""Reverse the string. """Reverse the string.

15
tests/test_var.py
View File

@ -962,6 +962,21 @@ def test_all_number_operations():
) )
@pytest.mark.parametrize(
("var", "expected"),
[
(Var.create(False), "false"),
(Var.create(True), "true"),
(Var.create("false"), 'isTrue("false")'),
(Var.create([1, 2, 3]), "isTrue([1, 2, 3])"),
(Var.create({"a": 1, "b": 2}), 'isTrue(({ ["a"] : 1, ["b"] : 2 }))'),
(Var("mysterious_var"), "isTrue(mysterious_var)"),
],
)
def test_boolify_operations(var, expected):
assert str(var.bool()) == expected
def test_index_operation(): def test_index_operation():
array_var = LiteralArrayVar.create([1, 2, 3, 4, 5]) array_var = LiteralArrayVar.create([1, 2, 3, 4, 5])
assert str(array_var[0]) == "[1, 2, 3, 4, 5].at(0)" assert str(array_var[0]) == "[1, 2, 3, 4, 5].at(0)"