laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

REF-1202: Upgrade bun version if it differs from reflex set version (#2206)

Browse Source
This commit is contained in:
Elijah Ahianyo 2023-11-20 23:21:17 +00:00 committed by GitHub
parent 88a3276356
commit 714edb3cde
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
reflex/utils/prerequisites.py
View File

@ -487,7 +487,9 @@ def install_bun():
return
# Skip if bun is already installed.
if os.path.exists(get_config().bun_path):
if os.path.exists(get_config().bun_path) and get_bun_version() == version.parse(
constants.Bun.VERSION
):
console.debug("Skipping bun installation as it is already installed.")
return

26
tests/utils/test_utils.py
View File

@ -437,6 +437,32 @@ def test_bun_install_without_unzip(mocker):
prerequisites.install_bun()
@pytest.mark.parametrize("bun_version", [constants.Bun.VERSION, "1.0.0"])
def test_bun_install_version(mocker, bun_version):
"""Test that bun is downloaded when the host version(installed by reflex)
different from the current version set in reflex.
Args:
mocker: Pytest mocker object.
bun_version: the host bun version
"""
mocker.patch("reflex.utils.prerequisites.constants.IS_WINDOWS", False)
mocker.patch("os.path.exists", return_value=True)
mocker.patch(
"reflex.utils.prerequisites.get_bun_version",
return_value=version.parse(bun_version),
)
mocker.patch("reflex.utils.path_ops.which")
mock = mocker.patch("reflex.utils.prerequisites.download_and_run")
prerequisites.install_bun()
if bun_version == constants.Bun.VERSION:
mock.assert_not_called()
else:
mock.assert_called_once()
@pytest.mark.parametrize("is_windows", [True, False])
def test_create_reflex_dir(mocker, is_windows):
"""Test that a reflex directory is created on initializing frontend