From 55ff03c0b73ba0f48e07883f47be012ed93da001 Mon Sep 17 00:00:00 2001 From: Elijah Date: Fri, 18 Oct 2024 13:25:03 +0000 Subject: [PATCH] resinstate connection banner api --- reflex/components/core/banner.py | 20 ++++++++------------ reflex/components/core/banner.pyi | 8 ++++++-- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/reflex/components/core/banner.py b/reflex/components/core/banner.py index f78df8f36..29897cffa 100644 --- a/reflex/components/core/banner.py +++ b/reflex/components/core/banner.py @@ -165,18 +165,16 @@ class ConnectionToaster(Toaster): class ConnectionBanner(Component): """A connection banner component.""" - # The component to render when there's a server connection error. - comp: Var[Optional[Component]] = Var.create(None) - @classmethod - def create(cls, **props) -> Component: + def create(cls, comp: Optional[Component] = None) -> Component: """Create a connection banner component. + Args: + comp: The component to render when there's a server connection error. + Returns: The connection banner component. """ - comp = props.pop("comp", None) - if not comp: comp = Flex.create( Text.create( @@ -197,18 +195,16 @@ class ConnectionBanner(Component): class ConnectionModal(Component): """A connection status modal window.""" - # The component to render when there's a server connection error. - comp: Var[Optional[Component]] = Var.create(None) - @classmethod - def create(cls, **props) -> Component: + def create(cls, comp: Optional[Component] = None) -> Component: """Create a connection banner component. + Args: + comp: The component to render when there's a server connection error. + Returns: The connection banner component. """ - comp = props.pop("comp", None) - if not comp: comp = Text.create(*default_connection_error()) return cond( diff --git a/reflex/components/core/banner.pyi b/reflex/components/core/banner.pyi index 553f46441..7c2be272c 100644 --- a/reflex/components/core/banner.pyi +++ b/reflex/components/core/banner.pyi @@ -143,7 +143,6 @@ class ConnectionBanner(Component): def create( # type: ignore cls, *children, - comp: Optional[Union[Component, Var[Optional[Component]]]] = None, style: Optional[Style] = None, key: Optional[Any] = None, id: Optional[Any] = None, @@ -169,6 +168,9 @@ class ConnectionBanner(Component): ) -> "ConnectionBanner": """Create a connection banner component. + Args: + comp: The component to render when there's a server connection error. + Returns: The connection banner component. """ @@ -180,7 +182,6 @@ class ConnectionModal(Component): def create( # type: ignore cls, *children, - comp: Optional[Union[Component, Var[Optional[Component]]]] = None, style: Optional[Style] = None, key: Optional[Any] = None, id: Optional[Any] = None, @@ -206,6 +207,9 @@ class ConnectionModal(Component): ) -> "ConnectionModal": """Create a connection banner component. + Args: + comp: The component to render when there's a server connection error. + Returns: The connection banner component. """