From 4b939caa7f2ce1f070ec4c944e8caa6d1c706efc Mon Sep 17 00:00:00 2001 From: Elijah Ahianyo Date: Wed, 29 May 2024 09:28:41 -0700 Subject: [PATCH] [REF-2895]Benchmarks getting skipped on merge (#3369) --- .github/workflows/benchmarks.yml | 2 +- .github/workflows/integration_tests.yml | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/benchmarks.yml b/.github/workflows/benchmarks.yml index 617519f75..4fbc937c2 100644 --- a/.github/workflows/benchmarks.yml +++ b/.github/workflows/benchmarks.yml @@ -23,7 +23,7 @@ env: jobs: reflex-web: - if: github.event.pull_request.merged == true +# if: github.event.pull_request.merged == true strategy: fail-fast: false matrix: diff --git a/.github/workflows/integration_tests.yml b/.github/workflows/integration_tests.yml index b83107504..0febb49e2 100644 --- a/.github/workflows/integration_tests.yml +++ b/.github/workflows/integration_tests.yml @@ -100,7 +100,7 @@ jobs: npm -v poetry run bash scripts/integration.sh ./reflex-examples/counter dev - name: Measure and upload .web size - if: ${{ env.DATABASE_URL && github.event.pull_request.merged == true }} + if: ${{ env.DATABASE_URL}} run: poetry run python scripts/benchmarks/benchmark_reflex_size.py --os "${{ matrix.os }}" --python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}" @@ -108,14 +108,12 @@ jobs: --branch-name "${{ github.head_ref || github.ref_name }}" --measurement-type "counter-app-dot-web" --path ./reflex-examples/counter/.web - name: Install hyperfine - if: github.event.pull_request.merged == true - run: cargo install --locked hyperfine + run: cargo install hyperfine - name: Benchmark imports - if: github.event.pull_request.merged == true working-directory: ./reflex-examples/counter run: hyperfine --warmup 3 "export POETRY_VIRTUALENVS_PATH=../../.venv; poetry run python counter/counter.py" --show-output --export-json "${{ env.OUTPUT_FILE }}" --shell bash - name: Upload Benchmarks - if : ${{ env.DATABASE_URL && github.event.pull_request.merged == true }} + if : ${{ env.DATABASE_URL }} run: poetry run python scripts/benchmarks/benchmark_imports.py --os "${{ matrix.os }}" --python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}" @@ -166,7 +164,7 @@ jobs: npm -v poetry run bash scripts/integration.sh ./reflex-web prod - name: Measure and upload .web size - if: ${{ env.DATABASE_URL && github.event.pull_request.merged == true }} + if: ${{ env.DATABASE_URL}} run: poetry run python scripts/benchmarks/benchmark_reflex_size.py --os "${{ matrix.os }}" --python-version "${{ matrix.python-version }}" --commit-sha "${{ github.sha }}"