From 444e9708092a91b6e64c0b9b10bbc1a7be7dedc9 Mon Sep 17 00:00:00 2001 From: Lendemor Date: Fri, 13 Dec 2024 01:36:19 +0100 Subject: [PATCH] remove hack and pass proper const for position --- .../.templates/jinja/web/pages/stateful_component.js.jinja2 | 4 ++-- reflex/compiler/templates.py | 1 + reflex/components/component.py | 2 -- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/reflex/.templates/jinja/web/pages/stateful_component.js.jinja2 b/reflex/.templates/jinja/web/pages/stateful_component.js.jinja2 index f993502d2..1a707d396 100644 --- a/reflex/.templates/jinja/web/pages/stateful_component.js.jinja2 +++ b/reflex/.templates/jinja/web/pages/stateful_component.js.jinja2 @@ -5,7 +5,7 @@ export function {{tag_name}} () { {{ hook }} {% endfor %} - {% for hook, data in component._get_all_hooks().items() if not data.position or data.position == positions.PRE_TRIGGER %} + {% for hook, data in component._get_all_hooks().items() if not data.position or data.position == hook_positions.PRE_TRIGGER %} {{ hook }} {% endfor %} @@ -13,7 +13,7 @@ export function {{tag_name}} () { {{ hook }} {% endfor %} - {% for hook,data in component._get_all_hooks().items() if data.position and data.position == positions.POST_TRIGGER %} + {% for hook,data in component._get_all_hooks().items() if data.position and data.position == hook_positions.POST_TRIGGER %} {{ hook }} {% endfor %} diff --git a/reflex/compiler/templates.py b/reflex/compiler/templates.py index c868a0cbb..488117953 100644 --- a/reflex/compiler/templates.py +++ b/reflex/compiler/templates.py @@ -45,6 +45,7 @@ class ReflexJinjaEnvironment(Environment): "on_load_internal": constants.CompileVars.ON_LOAD_INTERNAL, "update_vars_internal": constants.CompileVars.UPDATE_VARS_INTERNAL, "frontend_exception_state": constants.CompileVars.FRONTEND_EXCEPTION_STATE_FULL, + "hook_positions": constants.Hooks.HookPosition, } diff --git a/reflex/components/component.py b/reflex/components/component.py index b22b3ac6f..b4f3fb662 100644 --- a/reflex/components/component.py +++ b/reflex/components/component.py @@ -24,7 +24,6 @@ from typing import ( ) import reflex.state -from reflex import constants from reflex.base import Base from reflex.compiler.templates import STATEFUL_COMPONENT from reflex.components.core.breakpoints import Breakpoints @@ -2169,7 +2168,6 @@ class StatefulComponent(BaseComponent): tag_name=tag_name, memo_trigger_hooks=memo_trigger_hooks, component=component, - positions=constants.Hooks.HookPosition, ) @staticmethod