laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix non-default imports for NoSSRComponent (#1548)

Browse Source
This commit is contained in:
Masen Furer 2023-08-15 17:32:23 -07:00 committed by GitHub
parent 2ff823e89a
commit 2eefb5d26c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
reflex/components/component.py
View File

@ -799,4 +799,10 @@ class NoSSRComponent(Component):
def _get_custom_code(self) -> str: def _get_custom_code(self) -> str:
opts_fragment = ", { ssr: false });" opts_fragment = ", { ssr: false });"
library_import = f"const {self.tag} = dynamic(() => import('{self.library}')" library_import = f"const {self.tag} = dynamic(() => import('{self.library}')"
return "".join((library_import, opts_fragment)) mod_import = (
# https://nextjs.org/docs/pages/building-your-application/optimizing/lazy-loading#with-named-exports
f".then((mod) => mod.{self.tag})"
if not self.is_default
else ""
)
return "".join((library_import, mod_import, opts_fragment))

2
reflex/components/graphing/plotly.py
View File

@ -20,6 +20,8 @@ class Plotly(PlotlyLib):
tag = "Plot" tag = "Plot"
is_default = True
# The figure to display. This can be a plotly figure or a plotly data json. # The figure to display. This can be a plotly figure or a plotly data json.
data: Var[Figure] data: Var[Figure]

2
reflex/components/libs/react_player.py
View File

@ -15,6 +15,8 @@ class ReactPlayerComponent(NoSSRComponent):
tag = "ReactPlayer" tag = "ReactPlayer"
is_default = True
# The url of a video or song to play # The url of a video or song to play
url: Var[str] url: Var[str]