laipeng/reflex
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[ENG-4351] Add mapping for lucide icons (#4622)

Browse Source 
* [ENG-4351] Add mapping for lucide icons

For icon names that don't auto-translate to the correct lucide tag name,
provide manual override.

Fix #4621

* account for new mapping in unit tests
This commit is contained in:
Masen Furer 2025-01-10 15:23:16 -08:00 committed by GitHub
parent 427d7c56ab
commit 1e7a37bcf9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 25 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
reflex/components/lucide/icon.py
View File

@ -56,7 +56,12 @@ class Icon(LucideIconComponent):
"\nSee full list at https://lucide.dev/icons." "\nSee full list at https://lucide.dev/icons."
) )
props["tag"] = format.to_title_case(format.to_snake_case(props["tag"])) + "Icon" if props["tag"] in LUCIDE_ICON_MAPPING_OVERRIDE:
props["tag"] = LUCIDE_ICON_MAPPING_OVERRIDE[props["tag"]]
else:
props["tag"] = (
format.to_title_case(format.to_snake_case(props["tag"])) + "Icon"
)
props["alias"] = f"Lucide{props['tag']}" props["alias"] = f"Lucide{props['tag']}"
props.setdefault("color", "var(--current-color)") props.setdefault("color", "var(--current-color)")
return super().create(*children, **props) return super().create(*children, **props)
@ -1634,3 +1639,10 @@ LUCIDE_ICON_LIST = [
"zoom_in", "zoom_in",
"zoom_out", "zoom_out",
] ]
# The default transformation of some icon names doesn't match how the
# icons are exported from Lucide. Manual overrides can go here.
LUCIDE_ICON_MAPPING_OVERRIDE = {
"grid_2x_2_check": "Grid2x2Check",
"grid_2x_2_x": "Grid2x2X",
}

4
reflex/components/lucide/icon.pyi
View File

@ -1682,3 +1682,7 @@ LUCIDE_ICON_LIST = [
"zoom_in", "zoom_in",
"zoom_out", "zoom_out",
] ]
LUCIDE_ICON_MAPPING_OVERRIDE = {
"grid_2x_2_check": "Grid2x2Check",
"grid_2x_2_x": "Grid2x2X",
}

10
tests/units/components/lucide/test_icon.py
View File

@ -1,13 +1,19 @@
import pytest import pytest
from reflex.components.lucide.icon import LUCIDE_ICON_LIST, Icon from reflex.components.lucide.icon import (
LUCIDE_ICON_LIST,
LUCIDE_ICON_MAPPING_OVERRIDE,
Icon,
)
from reflex.utils import format from reflex.utils import format
@pytest.mark.parametrize("tag", LUCIDE_ICON_LIST) @pytest.mark.parametrize("tag", LUCIDE_ICON_LIST)
def test_icon(tag): def test_icon(tag):
icon = Icon.create(tag) icon = Icon.create(tag)
assert icon.alias == f"Lucide{format.to_title_case(tag)}Icon" assert icon.alias == "Lucide" + LUCIDE_ICON_MAPPING_OVERRIDE.get(
tag, f"{format.to_title_case(tag)}Icon"
)
def test_icon_missing_tag(): def test_icon_missing_tag():