From 87648af3eed2213552c84c80e11bf16a09b0eef5 Mon Sep 17 00:00:00 2001
From: abulvenz <a.eismann@senbax.de>
Date: Thu, 10 Oct 2024 00:33:34 +0000
Subject: [PATCH 1/9] fix: Determine var type from value. (#4143)

---
 reflex/vars/sequence.py | 5 ++++-
 tests/units/test_var.py | 3 +++
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/reflex/vars/sequence.py b/reflex/vars/sequence.py
index 3374ee10f..9b65507b7 100644
--- a/reflex/vars/sequence.py
+++ b/reflex/vars/sequence.py
@@ -545,7 +545,7 @@ class LiteralStringVar(LiteralVar, StringVar):
     def create(
         cls,
         value: str,
-        _var_type: GenericType | None = str,
+        _var_type: GenericType | None = None,
         _var_data: VarData | None = None,
     ) -> StringVar:
         """Create a var from a string value.
@@ -558,6 +558,9 @@ class LiteralStringVar(LiteralVar, StringVar):
         Returns:
             The var.
         """
+        # Determine var type in case the value is inherited from str.
+        _var_type = _var_type or type(value) or str
+
         if REFLEX_VAR_OPENING_TAG in value:
             strings_and_vals: list[Var | str] = []
             offset = 0
diff --git a/tests/units/test_var.py b/tests/units/test_var.py
index 8f907c24a..c02acefe6 100644
--- a/tests/units/test_var.py
+++ b/tests/units/test_var.py
@@ -1809,3 +1809,6 @@ def test_to_string_operation():
 
     assert cast(Var, TestState.email)._var_type == Email
     assert cast(Var, TestState.optional_email)._var_type == Optional[Email]
+
+    single_var = Var.create(Email())
+    assert single_var._var_type == Email

From 8ec3cf615725109904b67cdcb1d40e8d7f226a45 Mon Sep 17 00:00:00 2001
From: Khaleel Al-Adhami <khaleel.aladhami@gmail.com>
Date: Thu, 10 Oct 2024 12:18:18 -0700
Subject: [PATCH 2/9] remove dictify from state dict (#4141)

---
 reflex/state.py           | 7 +------
 tests/units/test_state.py | 6 +++---
 2 files changed, 4 insertions(+), 9 deletions(-)

diff --git a/reflex/state.py b/reflex/state.py
index 0941dfe07..f488602fa 100644
--- a/reflex/state.py
+++ b/reflex/state.py
@@ -1879,13 +1879,8 @@ class BaseState(Base, ABC, extra=pydantic.Extra.allow):
             self.dirty_vars.update(self._always_dirty_computed_vars)
             self._mark_dirty()
 
-        def dictify(value: Any):
-            if dataclasses.is_dataclass(value) and not isinstance(value, type):
-                return dataclasses.asdict(value)
-            return value
-
         base_vars = {
-            prop_name: dictify(self.get_value(getattr(self, prop_name)))
+            prop_name: self.get_value(getattr(self, prop_name))
             for prop_name in self.base_vars
         }
         if initial and include_computed:
diff --git a/tests/units/test_state.py b/tests/units/test_state.py
index a890c2aa4..6246618f6 100644
--- a/tests/units/test_state.py
+++ b/tests/units/test_state.py
@@ -1290,19 +1290,19 @@ def test_computed_var_depends_on_parent_non_cached():
     assert ps.dirty_vars == set()
     assert cs.dirty_vars == set()
 
-    dict1 = ps.dict()
+    dict1 = json.loads(json_dumps(ps.dict()))
     assert dict1[ps.get_full_name()] == {
         "no_cache_v": 1,
         "router": formatted_router,
     }
     assert dict1[cs.get_full_name()] == {"dep_v": 2}
-    dict2 = ps.dict()
+    dict2 = json.loads(json_dumps(ps.dict()))
     assert dict2[ps.get_full_name()] == {
         "no_cache_v": 3,
         "router": formatted_router,
     }
     assert dict2[cs.get_full_name()] == {"dep_v": 4}
-    dict3 = ps.dict()
+    dict3 = json.loads(json_dumps(ps.dict()))
     assert dict3[ps.get_full_name()] == {
         "no_cache_v": 5,
         "router": formatted_router,

From 1aed39a848e5013f118d9d9600098191080cc0ca Mon Sep 17 00:00:00 2001
From: benedikt-bartscher
 <31854409+benedikt-bartscher@users.noreply.github.com>
Date: Thu, 10 Oct 2024 21:18:57 +0200
Subject: [PATCH 3/9] catch ValueError("I/O operation on closed file.") if
 frontend crashes (#4150)

---
 reflex/testing.py | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/reflex/testing.py b/reflex/testing.py
index 7ea524f1c..6a45c51eb 100644
--- a/reflex/testing.py
+++ b/reflex/testing.py
@@ -394,9 +394,14 @@ class AppHarness:
 
         def consume_frontend_output():
             while True:
-                line = (
-                    self.frontend_process.stdout.readline()  # pyright: ignore [reportOptionalMemberAccess]
-                )
+                try:
+                    line = (
+                        self.frontend_process.stdout.readline()  # pyright: ignore [reportOptionalMemberAccess]
+                    )
+                # catch I/O operation on closed file.
+                except ValueError as e:
+                    print(e)
+                    break
                 if not line:
                     break
                 print(line)

From 6f586c8b8ff761dc41db707c8416adeeb82eab25 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thomas=20Brand=C3=A9ho?= <thomas.brandeho@gmail.com>
Date: Thu, 10 Oct 2024 12:22:35 -0700
Subject: [PATCH 4/9] let users pick state manager mode (#4041)

---
 reflex/config.py             | 16 ++++++++++++++++
 reflex/constants/__init__.py |  2 ++
 reflex/constants/state.py    | 11 +++++++++++
 reflex/state.py              | 35 +++++++++++++++++++++++------------
 reflex/utils/exceptions.py   |  8 ++++++++
 tests/units/test_state.py    |  1 +
 6 files changed, 61 insertions(+), 12 deletions(-)
 create mode 100644 reflex/constants/state.py

diff --git a/reflex/config.py b/reflex/config.py
index a5d66cb52..719d5c21f 100644
--- a/reflex/config.py
+++ b/reflex/config.py
@@ -9,6 +9,8 @@ import urllib.parse
 from pathlib import Path
 from typing import Any, Dict, List, Optional, Set, Union
 
+from reflex.utils.exceptions import ConfigError
+
 try:
     import pydantic.v1 as pydantic
 except ModuleNotFoundError:
@@ -220,6 +222,9 @@ class Config(Base):
     # Number of gunicorn workers from user
     gunicorn_workers: Optional[int] = None
 
+    # Indicate which type of state manager to use
+    state_manager_mode: constants.StateManagerMode = constants.StateManagerMode.DISK
+
     # Maximum expiration lock time for redis state manager
     redis_lock_expiration: int = constants.Expiration.LOCK
 
@@ -235,6 +240,9 @@ class Config(Base):
         Args:
             *args: The args to pass to the Pydantic init method.
             **kwargs: The kwargs to pass to the Pydantic init method.
+
+        Raises:
+            ConfigError: If some values in the config are invalid.
         """
         super().__init__(*args, **kwargs)
 
@@ -248,6 +256,14 @@ class Config(Base):
         self._non_default_attributes.update(kwargs)
         self._replace_defaults(**kwargs)
 
+        if (
+            self.state_manager_mode == constants.StateManagerMode.REDIS
+            and not self.redis_url
+        ):
+            raise ConfigError(
+                "REDIS_URL is required when using the redis state manager."
+            )
+
     @property
     def module(self) -> str:
         """Get the module name of the app.
diff --git a/reflex/constants/__init__.py b/reflex/constants/__init__.py
index e974ab915..8e61a3717 100644
--- a/reflex/constants/__init__.py
+++ b/reflex/constants/__init__.py
@@ -63,6 +63,7 @@ from .route import (
     RouteRegex,
     RouteVar,
 )
+from .state import StateManagerMode
 from .style import Tailwind
 
 __ALL__ = [
@@ -115,6 +116,7 @@ __ALL__ = [
     SETTER_PREFIX,
     SKIP_COMPILE_ENV_VAR,
     SocketEvent,
+    StateManagerMode,
     Tailwind,
     Templates,
     CompileVars,
diff --git a/reflex/constants/state.py b/reflex/constants/state.py
new file mode 100644
index 000000000..aa0e2f97f
--- /dev/null
+++ b/reflex/constants/state.py
@@ -0,0 +1,11 @@
+"""State-related constants."""
+
+from enum import Enum
+
+
+class StateManagerMode(str, Enum):
+    """State manager constants."""
+
+    DISK = "disk"
+    MEMORY = "memory"
+    REDIS = "redis"
diff --git a/reflex/state.py b/reflex/state.py
index f488602fa..38289d081 100644
--- a/reflex/state.py
+++ b/reflex/state.py
@@ -76,6 +76,7 @@ from reflex.utils.exceptions import (
     DynamicRouteArgShadowsStateVar,
     EventHandlerShadowsBuiltInStateMethod,
     ImmutableStateError,
+    InvalidStateManagerMode,
     LockExpiredError,
     SetUndefinedStateVarError,
     StateSchemaMismatchError,
@@ -2514,20 +2515,30 @@ class StateManager(Base, ABC):
         Args:
             state: The state class to use.
 
+        Raises:
+            InvalidStateManagerMode: If the state manager mode is invalid.
+
         Returns:
-            The state manager (either disk or redis).
+            The state manager (either disk, memory or redis).
         """
-        redis = prerequisites.get_redis()
-        if redis is not None:
-            # make sure expiration values are obtained only from the config object on creation
-            config = get_config()
-            return StateManagerRedis(
-                state=state,
-                redis=redis,
-                token_expiration=config.redis_token_expiration,
-                lock_expiration=config.redis_lock_expiration,
-            )
-        return StateManagerDisk(state=state)
+        config = get_config()
+        if config.state_manager_mode == constants.StateManagerMode.DISK:
+            return StateManagerMemory(state=state)
+        if config.state_manager_mode == constants.StateManagerMode.MEMORY:
+            return StateManagerDisk(state=state)
+        if config.state_manager_mode == constants.StateManagerMode.REDIS:
+            redis = prerequisites.get_redis()
+            if redis is not None:
+                # make sure expiration values are obtained only from the config object on creation
+                return StateManagerRedis(
+                    state=state,
+                    redis=redis,
+                    token_expiration=config.redis_token_expiration,
+                    lock_expiration=config.redis_lock_expiration,
+                )
+        raise InvalidStateManagerMode(
+            f"Expected one of: DISK, MEMORY, REDIS, got {config.state_manager_mode}"
+        )
 
     @abstractmethod
     async def get_state(self, token: str) -> BaseState:
diff --git a/reflex/utils/exceptions.py b/reflex/utils/exceptions.py
index 8bce605b5..35f59a0e1 100644
--- a/reflex/utils/exceptions.py
+++ b/reflex/utils/exceptions.py
@@ -5,6 +5,14 @@ class ReflexError(Exception):
     """Base exception for all Reflex exceptions."""
 
 
+class ConfigError(ReflexError):
+    """Custom exception for config related errors."""
+
+
+class InvalidStateManagerMode(ReflexError, ValueError):
+    """Raised when an invalid state manager mode is provided."""
+
+
 class ReflexRuntimeError(ReflexError, RuntimeError):
     """Custom RuntimeError for Reflex."""
 
diff --git a/tests/units/test_state.py b/tests/units/test_state.py
index 6246618f6..ae74cacce 100644
--- a/tests/units/test_state.py
+++ b/tests/units/test_state.py
@@ -3201,6 +3201,7 @@ import reflex as rx
 config = rx.Config(
     app_name="project1",
     redis_url="redis://localhost:6379",
+    state_manager_mode="redis",
     {config_items}
 )
 """

From 11abaf8055c00ac640f8791ca9810b16724aa7a3 Mon Sep 17 00:00:00 2001
From: Carlos <36110765+carlosabadia@users.noreply.github.com>
Date: Thu, 10 Oct 2024 21:57:46 +0200
Subject: [PATCH 5/9] default props comment for Grid (#4125)

---
 reflex/components/recharts/cartesian.py  |  8 ++++----
 reflex/components/recharts/cartesian.pyi | 24 ++++++++++++------------
 2 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/reflex/components/recharts/cartesian.py b/reflex/components/recharts/cartesian.py
index e4028053e..1b3a4e497 100644
--- a/reflex/components/recharts/cartesian.py
+++ b/reflex/components/recharts/cartesian.py
@@ -751,16 +751,16 @@ class ReferenceArea(Recharts):
 class Grid(Recharts):
     """A base class for grid components in Recharts."""
 
-    # The x-coordinate of grid.
+    # The x-coordinate of grid. Default: 0
     x: Var[int]
 
-    # The y-coordinate of grid.
+    # The y-coordinate of grid. Default: 0
     y: Var[int]
 
-    # The width of grid.
+    # The width of grid. Default: 0
     width: Var[int]
 
-    # The height of grid.
+    # The height of grid. Default: 0
     height: Var[int]
 
 
diff --git a/reflex/components/recharts/cartesian.pyi b/reflex/components/recharts/cartesian.pyi
index dc6965299..18d98c27b 100644
--- a/reflex/components/recharts/cartesian.pyi
+++ b/reflex/components/recharts/cartesian.pyi
@@ -2047,10 +2047,10 @@ class Grid(Recharts):
 
         Args:
             *children: The children of the component.
-            x: The x-coordinate of grid.
-            y: The y-coordinate of grid.
-            width: The width of grid.
-            height: The height of grid.
+            x: The x-coordinate of grid. Default: 0
+            y: The y-coordinate of grid. Default: 0
+            width: The width of grid. Default: 0
+            height: The height of grid. Default: 0
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.
@@ -2141,10 +2141,10 @@ class CartesianGrid(Grid):
             fill_opacity: The opacity of the background used to fill the space between grid lines.
             stroke_dasharray: The pattern of dashes and gaps used to paint the lines of the grid.
             stroke: the stroke color of grid. Default: rx.color("gray", 7)
-            x: The x-coordinate of grid.
-            y: The y-coordinate of grid.
-            width: The width of grid.
-            height: The height of grid.
+            x: The x-coordinate of grid. Default: 0
+            y: The y-coordinate of grid. Default: 0
+            width: The width of grid. Default: 0
+            height: The height of grid. Default: 0
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.
@@ -2245,10 +2245,10 @@ class CartesianAxis(Grid):
             label: If set a string or a number, default label will be drawn, and the option is content.
             mirror: If set true, flips ticks around the axis line, displaying the labels inside the chart instead of outside. Default: False
             tick_margin: The margin between tick line and tick.
-            x: The x-coordinate of grid.
-            y: The y-coordinate of grid.
-            width: The width of grid.
-            height: The height of grid.
+            x: The x-coordinate of grid. Default: 0
+            y: The y-coordinate of grid. Default: 0
+            width: The width of grid. Default: 0
+            height: The height of grid. Default: 0
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.

From 132a3d4d1d0b13b7d0ee4eb38b055469155fc075 Mon Sep 17 00:00:00 2001
From: Carlos <36110765+carlosabadia@users.noreply.github.com>
Date: Thu, 10 Oct 2024 21:58:38 +0200
Subject: [PATCH 6/9] default props comment for Funnel (#4119)

* default props comment for Funnel

* update
---
 reflex/components/recharts/cartesian.py  | 19 +++++++++++--------
 reflex/components/recharts/cartesian.pyi | 20 ++++++++++++--------
 2 files changed, 23 insertions(+), 16 deletions(-)

diff --git a/reflex/components/recharts/cartesian.py b/reflex/components/recharts/cartesian.py
index 1b3a4e497..457e35959 100644
--- a/reflex/components/recharts/cartesian.py
+++ b/reflex/components/recharts/cartesian.py
@@ -528,30 +528,33 @@ class Funnel(Recharts):
     # The source data, in which each element is an object.
     data: Var[List[Dict[str, Any]]]
 
-    # The key of a group of data which should be unique in an area chart.
+    # The key or getter of a group of data which should be unique in a FunnelChart.
     data_key: Var[Union[str, int]]
 
-    # The key or getter of a group of data which should be unique in a LineChart.
+    # The key of each sector's name. Default: "name"
     name_key: Var[str]
 
-    # The type of icon in legend. If set to 'none', no legend item will be rendered.
+    # The type of icon in legend. If set to 'none', no legend item will be rendered. Default: "line"
     legend_type: Var[LiteralLegendType]
 
-    # If set false, animation of line will be disabled.
+    # If set false, animation of line will be disabled. Default: True
     is_animation_active: Var[bool]
 
-    # Specifies when the animation should begin, the unit of this option is ms.
+    # Specifies when the animation should begin, the unit of this option is ms. Default: 0
     animation_begin: Var[int]
 
-    # Specifies the duration of animation, the unit of this option is ms.
+    # Specifies the duration of animation, the unit of this option is ms. Default: 1500
     animation_duration: Var[int]
 
-    # The type of easing function. 'ease' | 'ease-in' | 'ease-out' | 'ease-in-out' | 'linear'
+    # The type of easing function. 'ease' | 'ease-in' | 'ease-out' | 'ease-in-out' | 'linear'. Default "ease"
     animation_easing: Var[LiteralAnimationEasing]
 
-    # stroke color
+    # Stroke color. Default: rx.color("gray", 3)
     stroke: Var[Union[str, Color]] = LiteralVar.create(Color("gray", 3))
 
+    # The coordinates of all the trapezoids in the funnel, usually calculated internally.
+    trapezoids: Var[List[Dict[str, Any]]]
+
     # Valid children components
     _valid_children: List[str] = ["LabelList", "Cell"]
 
diff --git a/reflex/components/recharts/cartesian.pyi b/reflex/components/recharts/cartesian.pyi
index 18d98c27b..9e1dfb3bf 100644
--- a/reflex/components/recharts/cartesian.pyi
+++ b/reflex/components/recharts/cartesian.pyi
@@ -1481,6 +1481,9 @@ class Funnel(Recharts):
             ]
         ] = None,
         stroke: Optional[Union[Color, Var[Union[Color, str]], str]] = None,
+        trapezoids: Optional[
+            Union[List[Dict[str, Any]], Var[List[Dict[str, Any]]]]
+        ] = None,
         style: Optional[Style] = None,
         key: Optional[Any] = None,
         id: Optional[Any] = None,
@@ -1535,14 +1538,15 @@ class Funnel(Recharts):
         Args:
             *children: The children of the component.
             data: The source data, in which each element is an object.
-            data_key: The key of a group of data which should be unique in an area chart.
-            name_key: The key or getter of a group of data which should be unique in a LineChart.
-            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered.
-            is_animation_active: If set false, animation of line will be disabled.
-            animation_begin: Specifies when the animation should begin, the unit of this option is ms.
-            animation_duration: Specifies the duration of animation, the unit of this option is ms.
-            animation_easing: The type of easing function. 'ease' | 'ease-in' | 'ease-out' | 'ease-in-out' | 'linear'
-            stroke: stroke color
+            data_key: The key or getter of a group of data which should be unique in a FunnelChart.
+            name_key: The key of each sector's name. Default: "name"
+            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. Default: "line"
+            is_animation_active: If set false, animation of line will be disabled. Default: True
+            animation_begin: Specifies when the animation should begin, the unit of this option is ms. Default: 0
+            animation_duration: Specifies the duration of animation, the unit of this option is ms. Default: 1500
+            animation_easing: The type of easing function. 'ease' | 'ease-in' | 'ease-out' | 'ease-in-out' | 'linear'. Default "ease"
+            stroke: Stroke color. Default: rx.color("gray", 3)
+            trapezoids: The coordinates of all the trapezoids in the funnel, usually calculated internally.
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.

From 4a314394fd4decbb72963fd9acb88d0e53018ffa Mon Sep 17 00:00:00 2001
From: Carlos <36110765+carlosabadia@users.noreply.github.com>
Date: Thu, 10 Oct 2024 21:59:38 +0200
Subject: [PATCH 7/9] default props comment for ErrorBar (#4120)

* default props comment for ErrorBar

* union int float

* update
---
 reflex/components/recharts/cartesian.py  | 10 +++++-----
 reflex/components/recharts/cartesian.pyi | 14 ++++++--------
 reflex/components/recharts/recharts.py   |  2 +-
 reflex/components/recharts/recharts.pyi  |  2 +-
 4 files changed, 13 insertions(+), 15 deletions(-)

diff --git a/reflex/components/recharts/cartesian.py b/reflex/components/recharts/cartesian.py
index 457e35959..506a38235 100644
--- a/reflex/components/recharts/cartesian.py
+++ b/reflex/components/recharts/cartesian.py
@@ -596,20 +596,20 @@ class ErrorBar(Recharts):
 
     alias = "RechartsErrorBar"
 
-    # The direction of error bar. 'x' | 'y' | 'both'
+    # Only used for ScatterChart with error bars in two directions. Only accepts a value of "x" or "y" and makes the error bars lie in that direction.
     direction: Var[LiteralDirection]
 
     # The key of a group of data which should be unique in an area chart.
     data_key: Var[Union[str, int]]
 
-    # The width of the error bar ends.
+    # The width of the error bar ends. Default: 5
     width: Var[int]
 
-    # The stroke color of error bar.
+    # The stroke color of error bar. Default: rx.color("gray", 8)
     stroke: Var[Union[str, Color]] = LiteralVar.create(Color("gray", 8))
 
-    # The stroke width of error bar.
-    stroke_width: Var[int]
+    # The stroke width of error bar. Default: 1.5
+    stroke_width: Var[Union[int, float]]
 
 
 class Reference(Recharts):
diff --git a/reflex/components/recharts/cartesian.pyi b/reflex/components/recharts/cartesian.pyi
index 9e1dfb3bf..2e5788bb2 100644
--- a/reflex/components/recharts/cartesian.pyi
+++ b/reflex/components/recharts/cartesian.pyi
@@ -1566,13 +1566,11 @@ class ErrorBar(Recharts):
     def create(  # type: ignore
         cls,
         *children,
-        direction: Optional[
-            Union[Literal["both", "x", "y"], Var[Literal["both", "x", "y"]]]
-        ] = None,
+        direction: Optional[Union[Literal["x", "y"], Var[Literal["x", "y"]]]] = None,
         data_key: Optional[Union[Var[Union[int, str]], int, str]] = None,
         width: Optional[Union[Var[int], int]] = None,
         stroke: Optional[Union[Color, Var[Union[Color, str]], str]] = None,
-        stroke_width: Optional[Union[Var[int], int]] = None,
+        stroke_width: Optional[Union[Var[Union[float, int]], float, int]] = None,
         style: Optional[Style] = None,
         key: Optional[Any] = None,
         id: Optional[Any] = None,
@@ -1620,11 +1618,11 @@ class ErrorBar(Recharts):
 
         Args:
             *children: The children of the component.
-            direction: The direction of error bar. 'x' | 'y' | 'both'
+            direction: Only used for ScatterChart with error bars in two directions. Only accepts a value of "x" or "y" and makes the error bars lie in that direction.
             data_key: The key of a group of data which should be unique in an area chart.
-            width: The width of the error bar ends.
-            stroke: The stroke color of error bar.
-            stroke_width: The stroke width of error bar.
+            width: The width of the error bar ends. Default: 5
+            stroke: The stroke color of error bar. Default: rx.color("gray", 8)
+            stroke_width: The stroke width of error bar. Default: 1.5
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.
diff --git a/reflex/components/recharts/recharts.py b/reflex/components/recharts/recharts.py
index adb7bfdf9..a9b54af83 100644
--- a/reflex/components/recharts/recharts.py
+++ b/reflex/components/recharts/recharts.py
@@ -131,6 +131,6 @@ LiteralAreaType = Literal[
     "stepBefore",
     "stepAfter",
 ]
-LiteralDirection = Literal["x", "y", "both"]
+LiteralDirection = Literal["x", "y"]
 LiteralInterval = Literal["preserveStart", "preserveEnd", "preserveStartEnd"]
 LiteralSyncMethod = Literal["index", "value"]
diff --git a/reflex/components/recharts/recharts.pyi b/reflex/components/recharts/recharts.pyi
index 1f1937dc6..14065a213 100644
--- a/reflex/components/recharts/recharts.pyi
+++ b/reflex/components/recharts/recharts.pyi
@@ -242,6 +242,6 @@ LiteralAreaType = Literal[
     "stepBefore",
     "stepAfter",
 ]
-LiteralDirection = Literal["x", "y", "both"]
+LiteralDirection = Literal["x", "y"]
 LiteralInterval = Literal["preserveStart", "preserveEnd", "preserveStartEnd"]
 LiteralSyncMethod = Literal["index", "value"]

From ee3182a2df7e079e0d648ad24528ff93aa605d3f Mon Sep 17 00:00:00 2001
From: Carlos <36110765+carlosabadia@users.noreply.github.com>
Date: Thu, 10 Oct 2024 22:00:23 +0200
Subject: [PATCH 8/9] default props comment for Cartesian (#4114)

* default props comment for Cartesian

* add animation events

* update
---
 reflex/components/recharts/cartesian.py  |  30 +++++-
 reflex/components/recharts/cartesian.pyi | 112 ++++++++++++++++++++---
 2 files changed, 126 insertions(+), 16 deletions(-)

diff --git a/reflex/components/recharts/cartesian.py b/reflex/components/recharts/cartesian.py
index 506a38235..45ed0aea4 100644
--- a/reflex/components/recharts/cartesian.py
+++ b/reflex/components/recharts/cartesian.py
@@ -257,15 +257,39 @@ class Cartesian(Recharts):
     # The key of a group of data which should be unique in an area chart.
     data_key: Var[Union[str, int]]
 
-    # The id of x-axis which is corresponding to the data.
+    # The id of x-axis which is corresponding to the data. Default: 0
     x_axis_id: Var[Union[str, int]]
 
-    # The id of y-axis which is corresponding to the data.
+    # The id of y-axis which is corresponding to the data. Default: 0
     y_axis_id: Var[Union[str, int]]
 
-    # The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none'optional
+    # The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none' optional
     legend_type: Var[LiteralLegendType]
 
+    # If set false, animation of bar will be disabled. Default: True
+    is_animation_active: Var[bool]
+
+    # Specifies when the animation should begin, the unit of this option is ms. Default: 0
+    animation_begin: Var[int]
+
+    # Specifies the duration of animation, the unit of this option is ms. Default: 1500
+    animation_duration: Var[int]
+
+    # The type of easing function. Default: "ease"
+    animation_easing: Var[LiteralAnimationEasing]
+
+    # The unit of data. This option will be used in tooltip.
+    unit: Var[Union[str, int]]
+
+    # The name of data. This option will be used in tooltip and legend to represent the component. If no value was set to this option, the value of dataKey will be used alternatively.
+    name: Var[Union[str, int]]
+
+    # The customized event handler of animation start
+    on_animation_start: EventHandler[lambda: []]
+
+    # The customized event handler of animation end
+    on_animation_end: EventHandler[lambda: []]
+
     # The customized event handler of click on the component in this group
     on_click: EventHandler[empty_event]
 
diff --git a/reflex/components/recharts/cartesian.pyi b/reflex/components/recharts/cartesian.pyi
index 2e5788bb2..113790418 100644
--- a/reflex/components/recharts/cartesian.pyi
+++ b/reflex/components/recharts/cartesian.pyi
@@ -726,12 +726,29 @@ class Cartesian(Recharts):
                 ],
             ]
         ] = None,
+        is_animation_active: Optional[Union[Var[bool], bool]] = None,
+        animation_begin: Optional[Union[Var[int], int]] = None,
+        animation_duration: Optional[Union[Var[int], int]] = None,
+        animation_easing: Optional[
+            Union[
+                Literal["ease", "ease-in", "ease-in-out", "ease-out", "linear"],
+                Var[Literal["ease", "ease-in", "ease-in-out", "ease-out", "linear"]],
+            ]
+        ] = None,
+        unit: Optional[Union[Var[Union[int, str]], int, str]] = None,
+        name: Optional[Union[Var[Union[int, str]], int, str]] = None,
         style: Optional[Style] = None,
         key: Optional[Any] = None,
         id: Optional[Any] = None,
         class_name: Optional[Any] = None,
         autofocus: Optional[bool] = None,
         custom_attrs: Optional[Dict[str, Union[Var, str]]] = None,
+        on_animation_end: Optional[
+            Union[EventHandler, EventSpec, list, Callable, Var]
+        ] = None,
+        on_animation_start: Optional[
+            Union[EventHandler, EventSpec, list, Callable, Var]
+        ] = None,
         on_blur: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
         on_click: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
         on_context_menu: Optional[
@@ -775,9 +792,15 @@ class Cartesian(Recharts):
             *children: The children of the component.
             layout: The layout of bar in the chart, usually inherited from parent. 'horizontal' | 'vertical'
             data_key: The key of a group of data which should be unique in an area chart.
-            x_axis_id: The id of x-axis which is corresponding to the data.
-            y_axis_id: The id of y-axis which is corresponding to the data.
-            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none'optional
+            x_axis_id: The id of x-axis which is corresponding to the data. Default: 0
+            y_axis_id: The id of y-axis which is corresponding to the data. Default: 0
+            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none' optional
+            is_animation_active: If set false, animation of bar will be disabled. Default: True
+            animation_begin: Specifies when the animation should begin, the unit of this option is ms. Default: 0
+            animation_duration: Specifies the duration of animation, the unit of this option is ms. Default: 1500
+            animation_easing: The type of easing function. Default: "ease"
+            unit: The unit of data. This option will be used in tooltip.
+            name: The name of data. This option will be used in tooltip and legend to represent the component. If no value was set to this option, the value of dataKey will be used alternatively.
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.
@@ -894,12 +917,29 @@ class Area(Cartesian):
                 ],
             ]
         ] = None,
+        is_animation_active: Optional[Union[Var[bool], bool]] = None,
+        animation_begin: Optional[Union[Var[int], int]] = None,
+        animation_duration: Optional[Union[Var[int], int]] = None,
+        animation_easing: Optional[
+            Union[
+                Literal["ease", "ease-in", "ease-in-out", "ease-out", "linear"],
+                Var[Literal["ease", "ease-in", "ease-in-out", "ease-out", "linear"]],
+            ]
+        ] = None,
+        unit: Optional[Union[Var[Union[int, str]], int, str]] = None,
+        name: Optional[Union[Var[Union[int, str]], int, str]] = None,
         style: Optional[Style] = None,
         key: Optional[Any] = None,
         id: Optional[Any] = None,
         class_name: Optional[Any] = None,
         autofocus: Optional[bool] = None,
         custom_attrs: Optional[Dict[str, Union[Var, str]]] = None,
+        on_animation_end: Optional[
+            Union[EventHandler, EventSpec, list, Callable, Var]
+        ] = None,
+        on_animation_start: Optional[
+            Union[EventHandler, EventSpec, list, Callable, Var]
+        ] = None,
         on_blur: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
         on_click: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
         on_context_menu: Optional[
@@ -954,9 +994,15 @@ class Area(Cartesian):
             connect_nulls: Whether to connect a graph area across null points. Default: False
             layout: The layout of bar in the chart, usually inherited from parent. 'horizontal' | 'vertical'
             data_key: The key of a group of data which should be unique in an area chart.
-            x_axis_id: The id of x-axis which is corresponding to the data.
-            y_axis_id: The id of y-axis which is corresponding to the data.
-            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none'optional
+            x_axis_id: The id of x-axis which is corresponding to the data. Default: 0
+            y_axis_id: The id of y-axis which is corresponding to the data. Default: 0
+            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none' optional
+            is_animation_active: If set false, animation of bar will be disabled. Default: True
+            animation_begin: Specifies when the animation should begin, the unit of this option is ms. Default: 0
+            animation_duration: Specifies the duration of animation, the unit of this option is ms. Default: 1500
+            animation_easing: The type of easing function. Default: "ease"
+            unit: The unit of data. This option will be used in tooltip.
+            name: The name of data. This option will be used in tooltip and legend to represent the component. If no value was set to this option, the value of dataKey will be used alternatively.
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.
@@ -1029,12 +1075,27 @@ class Bar(Cartesian):
                 ],
             ]
         ] = None,
+        is_animation_active: Optional[Union[Var[bool], bool]] = None,
+        animation_begin: Optional[Union[Var[int], int]] = None,
+        animation_duration: Optional[Union[Var[int], int]] = None,
+        animation_easing: Optional[
+            Union[
+                Literal["ease", "ease-in", "ease-in-out", "ease-out", "linear"],
+                Var[Literal["ease", "ease-in", "ease-in-out", "ease-out", "linear"]],
+            ]
+        ] = None,
         style: Optional[Style] = None,
         key: Optional[Any] = None,
         id: Optional[Any] = None,
         class_name: Optional[Any] = None,
         autofocus: Optional[bool] = None,
         custom_attrs: Optional[Dict[str, Union[Var, str]]] = None,
+        on_animation_end: Optional[
+            Union[EventHandler, EventSpec, list, Callable, Var]
+        ] = None,
+        on_animation_start: Optional[
+            Union[EventHandler, EventSpec, list, Callable, Var]
+        ] = None,
         on_blur: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
         on_click: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
         on_context_menu: Optional[
@@ -1084,15 +1145,19 @@ class Bar(Cartesian):
             stack_id: The stack id of bar, when two bars have the same value axis and same stack_id, then the two bars are stacked in order.
             unit: The unit of data. This option will be used in tooltip.
             min_point_size: The minimal height of a bar in a horizontal BarChart, or the minimal width of a bar in a vertical BarChart. By default, 0 values are not shown. To visualize a 0 (or close to zero) point, set the minimal point size to a pixel value like 3. In stacked bar charts, minPointSize might not be respected for tightly packed values. So we strongly recommend not using this prop in stacked BarCharts.
-            name: The name of data. This option will be used in tooltip and legend to represent a bar. If no value was set to this option, the value of dataKey will be used alternatively.
+            name: The name of data. This option will be used in tooltip and legend to represent the component. If no value was set to this option, the value of dataKey will be used alternatively.
             bar_size: Size of the bar (if one bar_size is set then a bar_size must be set for all bars)
             max_bar_size: Max size of the bar
             radius: If set a value, the option is the radius of all the rounded corners. If set a array, the option are in turn the radiuses of top-left corner, top-right corner, bottom-right corner, bottom-left corner. Default: 0
             layout: The layout of bar in the chart, usually inherited from parent. 'horizontal' | 'vertical'
             data_key: The key of a group of data which should be unique in an area chart.
-            x_axis_id: The id of x-axis which is corresponding to the data.
-            y_axis_id: The id of y-axis which is corresponding to the data.
-            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none'optional
+            x_axis_id: The id of x-axis which is corresponding to the data. Default: 0
+            y_axis_id: The id of y-axis which is corresponding to the data. Default: 0
+            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none' optional
+            is_animation_active: If set false, animation of bar will be disabled. Default: True
+            animation_begin: Specifies when the animation should begin, the unit of this option is ms. Default: 0
+            animation_duration: Specifies the duration of animation, the unit of this option is ms. Default: 1500
+            animation_easing: The type of easing function. Default: "ease"
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.
@@ -1207,12 +1272,28 @@ class Line(Cartesian):
                 ],
             ]
         ] = None,
+        is_animation_active: Optional[Union[Var[bool], bool]] = None,
+        animation_begin: Optional[Union[Var[int], int]] = None,
+        animation_duration: Optional[Union[Var[int], int]] = None,
+        animation_easing: Optional[
+            Union[
+                Literal["ease", "ease-in", "ease-in-out", "ease-out", "linear"],
+                Var[Literal["ease", "ease-in", "ease-in-out", "ease-out", "linear"]],
+            ]
+        ] = None,
+        name: Optional[Union[Var[Union[int, str]], int, str]] = None,
         style: Optional[Style] = None,
         key: Optional[Any] = None,
         id: Optional[Any] = None,
         class_name: Optional[Any] = None,
         autofocus: Optional[bool] = None,
         custom_attrs: Optional[Dict[str, Union[Var, str]]] = None,
+        on_animation_end: Optional[
+            Union[EventHandler, EventSpec, list, Callable, Var]
+        ] = None,
+        on_animation_start: Optional[
+            Union[EventHandler, EventSpec, list, Callable, Var]
+        ] = None,
         on_blur: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
         on_click: Optional[Union[EventHandler, EventSpec, list, Callable, Var]] = None,
         on_context_menu: Optional[
@@ -1267,9 +1348,14 @@ class Line(Cartesian):
             stroke_dasharray: The pattern of dashes and gaps used to paint the line.
             layout: The layout of bar in the chart, usually inherited from parent. 'horizontal' | 'vertical'
             data_key: The key of a group of data which should be unique in an area chart.
-            x_axis_id: The id of x-axis which is corresponding to the data.
-            y_axis_id: The id of y-axis which is corresponding to the data.
-            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none'optional
+            x_axis_id: The id of x-axis which is corresponding to the data. Default: 0
+            y_axis_id: The id of y-axis which is corresponding to the data. Default: 0
+            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. 'line' | 'plainline' | 'square' | 'rect'| 'circle' | 'cross' | 'diamond' | 'star' | 'triangle' | 'wye' | 'none' optional
+            is_animation_active: If set false, animation of bar will be disabled. Default: True
+            animation_begin: Specifies when the animation should begin, the unit of this option is ms. Default: 0
+            animation_duration: Specifies the duration of animation, the unit of this option is ms. Default: 1500
+            animation_easing: The type of easing function. Default: "ease"
+            name: The name of data. This option will be used in tooltip and legend to represent the component. If no value was set to this option, the value of dataKey will be used alternatively.
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.

From ec6990fb71db466e8fe5204d6a012693cf7af49a Mon Sep 17 00:00:00 2001
From: Carlos <36110765+carlosabadia@users.noreply.github.com>
Date: Thu, 10 Oct 2024 22:04:49 +0200
Subject: [PATCH 9/9] default props comment for RadialBar (#4105)

* default props comment for RadialBar

* update
---
 reflex/components/recharts/polar.py  | 21 +++++++-----
 reflex/components/recharts/polar.pyi | 51 +++++++++++++++++++++++-----
 2 files changed, 54 insertions(+), 18 deletions(-)

diff --git a/reflex/components/recharts/polar.py b/reflex/components/recharts/polar.py
index 828000447..158c0e729 100644
--- a/reflex/components/recharts/polar.py
+++ b/reflex/components/recharts/polar.py
@@ -158,31 +158,34 @@ class RadialBar(Recharts):
 
     alias = "RechartsRadialBar"
 
+    # The source data which each element is an object.
+    data: Var[List[Dict[str, Any]]]
+
     # The key of a group of data which should be unique to show the meaning of angle axis.
     data_key: Var[Union[str, int]]
 
-    # Min angle of each bar. A positive value between 0 and 360.
+    # Min angle of each bar. A positive value between 0 and 360. Default: 0
     min_angle: Var[int]
 
-    # Type of legend
-    legend_type: Var[str]
+    # The type of icon in legend. If set to 'none', no legend item will be rendered. Default: "rect"
+    legend_type: Var[LiteralLegendType]
 
-    # If false set, labels will not be drawn.
+    # If false set, labels will not be drawn. If true set, labels will be drawn which have the props calculated internally. Default: False
     label: Var[Union[bool, Dict[str, Any]]]
 
-    # If false set, background sector will not be drawn.
+    # If false set, background sector will not be drawn. Default: False
     background: Var[Union[bool, Dict[str, Any]]]
 
-    # If set false, animation of radial bars will be disabled. By default true in CSR, and false in SSR
+    # If set false, animation of radial bars will be disabled. Default: True
     is_animation_active: Var[bool]
 
-    # Specifies when the animation should begin, the unit of this option is ms. By default 0
+    # Specifies when the animation should begin, the unit of this option is ms. Default: 0
     animation_begin: Var[int]
 
-    # Specifies the duration of animation, the unit of this option is ms. By default 1500
+    # Specifies the duration of animation, the unit of this option is ms. Default 1500
     animation_duration: Var[int]
 
-    # The type of easing function. 'ease' | 'ease-in' | 'ease-out' | 'ease-in-out' | 'linear'. By default 'ease'
+    # The type of easing function. 'ease' | 'ease-in' | 'ease-out' | 'ease-in-out' | 'linear'. Default: "ease"
     animation_easing: Var[LiteralAnimationEasing]
 
     # Valid children components
diff --git a/reflex/components/recharts/polar.pyi b/reflex/components/recharts/polar.pyi
index 32e7e5b76..be3bd2d09 100644
--- a/reflex/components/recharts/polar.pyi
+++ b/reflex/components/recharts/polar.pyi
@@ -230,9 +230,41 @@ class RadialBar(Recharts):
     def create(  # type: ignore
         cls,
         *children,
+        data: Optional[Union[List[Dict[str, Any]], Var[List[Dict[str, Any]]]]] = None,
         data_key: Optional[Union[Var[Union[int, str]], int, str]] = None,
         min_angle: Optional[Union[Var[int], int]] = None,
-        legend_type: Optional[Union[Var[str], str]] = None,
+        legend_type: Optional[
+            Union[
+                Literal[
+                    "circle",
+                    "cross",
+                    "diamond",
+                    "line",
+                    "none",
+                    "plainline",
+                    "rect",
+                    "square",
+                    "star",
+                    "triangle",
+                    "wye",
+                ],
+                Var[
+                    Literal[
+                        "circle",
+                        "cross",
+                        "diamond",
+                        "line",
+                        "none",
+                        "plainline",
+                        "rect",
+                        "square",
+                        "star",
+                        "triangle",
+                        "wye",
+                    ]
+                ],
+            ]
+        ] = None,
         label: Optional[
             Union[Dict[str, Any], Var[Union[Dict[str, Any], bool]], bool]
         ] = None,
@@ -282,15 +314,16 @@ class RadialBar(Recharts):
 
         Args:
             *children: The children of the component.
+            data: The source data which each element is an object.
             data_key: The key of a group of data which should be unique to show the meaning of angle axis.
-            min_angle: Min angle of each bar. A positive value between 0 and 360.
-            legend_type: Type of legend
-            label: If false set, labels will not be drawn.
-            background: If false set, background sector will not be drawn.
-            is_animation_active: If set false, animation of radial bars will be disabled. By default true in CSR, and false in SSR
-            animation_begin: Specifies when the animation should begin, the unit of this option is ms. By default 0
-            animation_duration: Specifies the duration of animation, the unit of this option is ms. By default 1500
-            animation_easing: The type of easing function. 'ease' | 'ease-in' | 'ease-out' | 'ease-in-out' | 'linear'. By default 'ease'
+            min_angle: Min angle of each bar. A positive value between 0 and 360. Default: 0
+            legend_type: The type of icon in legend. If set to 'none', no legend item will be rendered. Default: "rect"
+            label: If false set, labels will not be drawn. If true set, labels will be drawn which have the props calculated internally. Default: False
+            background: If false set, background sector will not be drawn. Default: False
+            is_animation_active: If set false, animation of radial bars will be disabled. Default: True
+            animation_begin: Specifies when the animation should begin, the unit of this option is ms. Default: 0
+            animation_duration: Specifies the duration of animation, the unit of this option is ms. Default 1500
+            animation_easing: The type of easing function. 'ease' | 'ease-in' | 'ease-out' | 'ease-in-out' | 'linear'. Default: "ease"
             style: The style of the component.
             key: A unique key for the component.
             id: The id for the component.