From 03eb258ee765d02a751125e3d4e1203168649913 Mon Sep 17 00:00:00 2001 From: Masen Furer Date: Wed, 27 Mar 2024 16:22:58 -0700 Subject: [PATCH] [REF-2416] Pass shell=True when starting AppHarness on Windows (#2944) In exec.py, run_process_and_launch_url already passes `shell=True` on windows, but the AppHarness has never really been used on Windows, so we were missing this detail. Fix #2941 --- reflex/testing.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/reflex/testing.py b/reflex/testing.py index f72221ed7..fcaeefdff 100644 --- a/reflex/testing.py +++ b/reflex/testing.py @@ -73,8 +73,9 @@ FRONTEND_POPEN_ARGS = {} T = TypeVar("T") TimeoutType = Optional[Union[int, float]] -if platform.system == "Windows": +if platform.system() == "Windows": FRONTEND_POPEN_ARGS["creationflags"] = subprocess.CREATE_NEW_PROCESS_GROUP # type: ignore + FRONTEND_POPEN_ARGS["shell"] = True else: FRONTEND_POPEN_ARGS["start_new_session"] = True