mirror of
https://github.com/temporalio/temporal.git
synced 2026-08-30 18:41:49 -07:00
bee6fe2846
## What changed? - The `ChasmRequestInterceptor` has been split in two! `ChasmRequestEngineInterceptor` does everything except inject `chasm.VisibilityManager`, which is done by `ChasmRequestVisibilityInterceptor`. - Note that the test doesn't include a matching `hasVisibilityCtx` assert to `hasEngineCtx` because I think making that getter public would make the public API earnestly more confusing for consumers ## Why? - Frontend needs visibilityMgr injected so that it can handle FE->Vis queries without hopping through history. The previous interceptor assumed `chasm.Engine` was always available, which it isn't, for history. I'd also workshopped making engine an optional fx parameter, but eh. ## How did you test it? - Validated with scheduler functional tests, which use `chasm.ListExecutions` directly in frontend's `WorkflowHandler`.
114 lines
2.8 KiB
Go
114 lines
2.8 KiB
Go
package chasm_test
|
|
|
|
import (
|
|
"context"
|
|
"net"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
"go.temporal.io/server/chasm"
|
|
"go.temporal.io/server/chasm/lib/tests/gen/testspb/v1"
|
|
"go.temporal.io/server/common/log"
|
|
"go.temporal.io/server/common/metrics"
|
|
"go.uber.org/mock/gomock"
|
|
"google.golang.org/grpc"
|
|
"google.golang.org/grpc/credentials/insecure"
|
|
)
|
|
|
|
type ServiceHandler struct {
|
|
testspb.UnimplementedTestServiceServer
|
|
}
|
|
|
|
func (h ServiceHandler) Test(
|
|
ctx context.Context,
|
|
req *testspb.TestRequest,
|
|
) (resp *testspb.TestResponse, err error) {
|
|
hasEngineCtx := chasm.EngineFromContext(ctx) != nil
|
|
|
|
return &testspb.TestResponse{
|
|
RequestId: req.RequestId,
|
|
HasEngineCtx: hasEngineCtx,
|
|
}, nil
|
|
}
|
|
|
|
type ServiceLibrary struct {
|
|
chasm.UnimplementedLibrary
|
|
}
|
|
|
|
func NewServiceLibrary() *ServiceLibrary {
|
|
return &ServiceLibrary{}
|
|
}
|
|
|
|
func (l *ServiceLibrary) RegisterServices(server *grpc.Server) {
|
|
testspb.RegisterTestServiceServer(server, ServiceHandler{})
|
|
}
|
|
|
|
func TestChasmEngineInterceptor_ShouldRespond(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
|
|
mockEngine := chasm.NewMockEngine(ctrl)
|
|
engineInterceptor := chasm.ChasmEngineInterceptorProvider(
|
|
mockEngine,
|
|
log.NewNoopLogger(),
|
|
metrics.NoopMetricsHandler,
|
|
)
|
|
|
|
server, address := startTestServer(t, grpc.UnaryInterceptor(engineInterceptor.Intercept))
|
|
defer server.Stop()
|
|
|
|
response := testRoundTrip(t, address)
|
|
require.True(t, response.HasEngineCtx)
|
|
}
|
|
|
|
func TestChasmVisibilityInterceptor_ShouldRespond(t *testing.T) {
|
|
ctrl := gomock.NewController(t)
|
|
|
|
mockVisibilityManager := chasm.NewMockVisibilityManager(ctrl)
|
|
visibilityInterceptor := chasm.ChasmVisibilityInterceptorProvider(mockVisibilityManager)
|
|
|
|
server, address := startTestServer(t, grpc.UnaryInterceptor(visibilityInterceptor.Intercept))
|
|
defer server.Stop()
|
|
testRoundTrip(t, address)
|
|
}
|
|
|
|
func testRoundTrip(t *testing.T, address string) *testspb.TestResponse {
|
|
conn, err := grpc.NewClient(address, grpc.WithTransportCredentials(insecure.NewCredentials()))
|
|
if err != nil {
|
|
t.Fatalf("failed to connect: %v", err)
|
|
}
|
|
|
|
defer func() {
|
|
err := conn.Close()
|
|
require.NoError(t, err)
|
|
}()
|
|
|
|
client := testspb.NewTestServiceClient(conn)
|
|
|
|
var response *testspb.TestResponse
|
|
response, err = client.Test(context.Background(), &testspb.TestRequest{
|
|
RequestId: "test-request-id",
|
|
})
|
|
require.NoError(t, err)
|
|
require.Equal(t, "test-request-id", response.GetRequestId())
|
|
|
|
return response
|
|
}
|
|
|
|
func startTestServer(t *testing.T, opt ...grpc.ServerOption) (*grpc.Server, string) {
|
|
server := grpc.NewServer(opt...)
|
|
listener, err := net.Listen("tcp", "localhost:0") // :0 picks a random available port
|
|
if err != nil {
|
|
panic(err)
|
|
}
|
|
|
|
lib := NewServiceLibrary()
|
|
lib.RegisterServices(server)
|
|
|
|
go func() {
|
|
err := server.Serve(listener)
|
|
require.NoError(t, err)
|
|
}()
|
|
|
|
return server, listener.Addr().String()
|
|
}
|