mirror of
https://github.com/temporalio/temporal.git
synced 2026-08-31 02:51:51 -07:00
## What changed? The PR adds a workflowTaskQueueName parameter to `ValidateAndNormalizeEmbeddedActivity` and uses it as the parentTaskQueue to leverage the existing CheckInternalPerNsTaskQueueAllowed check. This blocks normal workflows from scheduling activities on temporal-sys-per-ns-tq while allowing internal per-ns-tq workflows to do so. ## Why? Activities cannot be scheduled in the internal per-ns-tq unless they are initiated from an internal workflow. ## How did you test it? - [x] built - [x] run locally and tested manually - [x] covered by existing tests - [x] added new unit test(s) - [x] added new functional test(s) ## Potential risks may potentially break features or tests (need to carefully run regression
150 lines
5.2 KiB
Go
150 lines
5.2 KiB
Go
package tqid
|
|
|
|
import (
|
|
"strings"
|
|
|
|
enumspb "go.temporal.io/api/enums/v1"
|
|
"go.temporal.io/api/serviceerror"
|
|
taskqueuepb "go.temporal.io/api/taskqueue/v1"
|
|
"go.temporal.io/server/common/enums"
|
|
"go.temporal.io/server/common/primitives"
|
|
)
|
|
|
|
const (
|
|
reservedTaskQueuePrefix = "/_sys/"
|
|
)
|
|
|
|
// NormalizeAndValidatePartition validates a TaskQueue proto object as a task queue partition,
|
|
// and normalizes its fields.
|
|
// Note that a TaskQueue proto holds a task queue partition in the general case, not necessarily
|
|
// a high-level task queue.
|
|
// It checks the TaskQueue's name for emptiness, length, UTF-8 validity, and whitespace.
|
|
// For sticky queues, it also validates the NormalName.
|
|
// If the name is empty and defaultVal is provided, it sets the name to defaultVal.
|
|
// If the Kind is unspecified, it sets it to NORMAL.
|
|
//
|
|
// Parameters:
|
|
// - taskQueue: The TaskQueue to validate and normalize. If nil, returns an error.
|
|
// - defaultName: Default name to use if taskQueue name is empty.
|
|
// - maxIDLengthLimit: Maximum allowed length for the TaskQueue name.
|
|
//
|
|
// Returns an error if validation fails, nil otherwise.
|
|
func NormalizeAndValidatePartition(
|
|
partition *taskqueuepb.TaskQueue,
|
|
defaultName string,
|
|
maxIDLengthLimit int,
|
|
) error {
|
|
return normalizeAndValidate(partition, defaultName, maxIDLengthLimit, false)
|
|
}
|
|
|
|
// NormalizeAndValidate validates a TaskQueue proto object as a top-level task queue or
|
|
// a sticky queue and normalizes its fields.
|
|
// Note that a TaskQueue proto holds a task queue partition in the general case, not necessarily
|
|
// a top-level task queue.
|
|
// It checks the TaskQueue's name for emptiness, length, UTF-8 validity, and whitespace.
|
|
// For sticky queues, it also validates the NormalName.
|
|
// If the name is empty and defaultVal is provided, it sets the name to defaultVal.
|
|
// If the Kind is unspecified, it sets it to NORMAL.
|
|
//
|
|
// Parameters:
|
|
// - taskQueue: The TaskQueue to validate and normalize. If nil, returns an error.
|
|
// - defaultName: Default name to use if taskQueue name is empty.
|
|
// - maxIDLengthLimit: Maximum allowed length for the TaskQueue name.
|
|
//
|
|
// Returns an error if validation fails, nil otherwise.
|
|
func NormalizeAndValidate(
|
|
taskQueue *taskqueuepb.TaskQueue,
|
|
defaultName string,
|
|
maxIDLengthLimit int,
|
|
) error {
|
|
return normalizeAndValidate(taskQueue, defaultName, maxIDLengthLimit, true)
|
|
}
|
|
|
|
// NormalizeAndValidateUserDefined is like NormalizeAndValidate, but specifically for external
|
|
// user-defined task queues, disallowing use of internal per-namespace task queues.
|
|
// Prioritise using this over NormalizeAndValidate() when possible.
|
|
//
|
|
// Parameters:
|
|
// - taskQueue: The TaskQueue to validate and normalize. If nil, returns an error.
|
|
// - defaultName: Default name to use if taskQueue name is empty.
|
|
// - parentTaskQueue: The TaskQueue of the parent component, if any. Can be empty.
|
|
// - maxIDLengthLimit: Maximum allowed length for the TaskQueue name.
|
|
//
|
|
// Returns an error if validation fails, nil otherwise.
|
|
func NormalizeAndValidateUserDefined(
|
|
taskQueue *taskqueuepb.TaskQueue,
|
|
defaultName string,
|
|
parentTaskQueue string,
|
|
maxIDLengthLimit int,
|
|
) error {
|
|
if err := normalizeAndValidate(taskQueue, defaultName, maxIDLengthLimit, true); err != nil {
|
|
return err
|
|
}
|
|
// reminder: if this check goes first, taskQueue.GetName() may not be normalized yet.
|
|
return primitives.CheckInternalPerNsTaskQueueAllowed(taskQueue.GetName(), parentTaskQueue)
|
|
}
|
|
|
|
func normalizeAndValidate(
|
|
taskQueue *taskqueuepb.TaskQueue,
|
|
defaultName string,
|
|
maxIDLengthLimit int,
|
|
expectRootPartition bool,
|
|
) error {
|
|
if taskQueue == nil {
|
|
return serviceerror.NewInvalidArgument("taskQueue is not set")
|
|
}
|
|
|
|
enums.SetDefaultTaskQueueKind(&taskQueue.Kind)
|
|
|
|
if taskQueue.GetName() == "" {
|
|
if defaultName == "" {
|
|
return serviceerror.NewInvalidArgument("missing task queue name")
|
|
}
|
|
taskQueue.Name = defaultName
|
|
}
|
|
|
|
if err := validate(taskQueue.GetName(), maxIDLengthLimit, expectRootPartition); err != nil {
|
|
return err
|
|
}
|
|
|
|
if taskQueue.GetKind() == enumspb.TASK_QUEUE_KIND_STICKY {
|
|
normalName := taskQueue.GetNormalName()
|
|
// Old SDKs might not send the normal name, so we accept empty normal names for the time being.
|
|
if normalName != "" {
|
|
if err := validate(normalName, maxIDLengthLimit, false); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// Validate checks if a given task queue name is valid.
|
|
// It verifies the name is not empty, does not exceed the maximum length,
|
|
// and is a valid UTF-8 string.
|
|
//
|
|
// Parameters:
|
|
// - name: The task queue name to validate.
|
|
// - maxLength: The maximum allowed length for the name.
|
|
//
|
|
// Returns an error if the name is invalid, nil otherwise.
|
|
func Validate(taskQueueName string, maxLength int) error {
|
|
return validate(taskQueueName, maxLength, true)
|
|
}
|
|
|
|
func validate(taskQueueName string, maxLength int, expectRootPartition bool) error {
|
|
if taskQueueName == "" {
|
|
return serviceerror.NewInvalidArgument("taskQueue is not set")
|
|
}
|
|
if len(taskQueueName) > maxLength {
|
|
return serviceerror.NewInvalidArgument("taskQueue length exceeds limit")
|
|
}
|
|
|
|
if expectRootPartition && strings.HasPrefix(taskQueueName, reservedTaskQueuePrefix) {
|
|
return serviceerror.NewInvalidArgumentf("task queue name cannot start with reserved prefix %v", reservedTaskQueuePrefix)
|
|
}
|
|
|
|
return nil
|
|
}
|