Remove support for standard visibility (#5387)

## What changed?
<!-- Describe what has changed in this PR -->
Remove support for standard visibility

## Why?
<!-- Tell your future self why have you made these changes -->
Standard visibility is deprecated.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
This commit is contained in:
Rodrigo Zhou
2024-02-29 12:05:20 -06:00
committed by GitHub
parent 39ec799966
commit f6937601ef
126 changed files with 405 additions and 5437 deletions

View File

@@ -45,7 +45,7 @@ docker compose run integration-test-cassandra make integration-test-coverage
```
or run integration tests with MySQL:
```bash
docker compose run integration-test-mysql make integration-test-coverage
docker compose run integration-test-mysql8 make integration-test-coverage
```
## Testing the build in Buildkite

View File

@@ -173,27 +173,6 @@ services:
aliases:
- integration-test
integration-test-mysql:
build:
context: ../..
dockerfile: ./develop/buildkite/Dockerfile
environment:
- "MYSQL_SEEDS=mysql"
- "ES_SEEDS=elasticsearch"
- "ES_VERSION=v7"
- "PERSISTENCE_TYPE=sql"
- "PERSISTENCE_DRIVER=mysql"
- "TEMPORAL_VERSION_CHECK_DISABLED=1"
depends_on:
- mysql
- elasticsearch
volumes:
- ../../.testoutput:/temporal/.testoutput
networks:
services-network:
aliases:
- integration-test
integration-test-mysql8:
build:
context: ../..
@@ -212,48 +191,6 @@ services:
aliases:
- integration-test
integration-test-postgresql:
build:
context: ../..
dockerfile: ./develop/buildkite/Dockerfile
environment:
- "POSTGRES_SEEDS=postgresql"
- "ES_SEEDS=elasticsearch"
- "ES_VERSION=v7"
- "PERSISTENCE_TYPE=sql"
- "PERSISTENCE_DRIVER=postgres"
- "TEMPORAL_VERSION_CHECK_DISABLED=1"
depends_on:
- postgresql
- elasticsearch
volumes:
- ../../.testoutput:/temporal/.testoutput
networks:
services-network:
aliases:
- integration-test
integration-test-postgresql-pgx:
build:
context: ../..
dockerfile: ./develop/buildkite/Dockerfile
environment:
- "POSTGRES_SEEDS=postgresql"
- "ES_SEEDS=elasticsearch"
- "ES_VERSION=v7"
- "PERSISTENCE_TYPE=sql"
- "PERSISTENCE_DRIVER=postgres_pgx"
- "TEMPORAL_VERSION_CHECK_DISABLED=1"
depends_on:
- postgresql
- elasticsearch
volumes:
- ../../.testoutput:/temporal/.testoutput
networks:
services-network:
aliases:
- integration-test
integration-test-postgresql12:
build:
context: ../..
@@ -327,28 +264,6 @@ services:
aliases:
- integration-test-xdc
integration-test-xdc-mysql:
build:
context: ../..
dockerfile: ./develop/buildkite/Dockerfile
environment:
- "MYSQL_SEEDS=mysql"
- "ES_SEEDS=elasticsearch"
- "ES_VERSION=v7"
- "PERSISTENCE_TYPE=sql"
- "PERSISTENCE_DRIVER=mysql"
- "TEST_RUN_COUNT=10"
- "TEMPORAL_VERSION_CHECK_DISABLED=1"
depends_on:
- mysql
- elasticsearch
volumes:
- ../../.testoutput:/temporal/.testoutput
networks:
services-network:
aliases:
- integration-test-xdc
integration-test-xdc-mysql8:
build:
context: ../..
@@ -368,50 +283,6 @@ services:
aliases:
- integration-test-xdc
integration-test-xdc-postgresql:
build:
context: ../..
dockerfile: ./develop/buildkite/Dockerfile
environment:
- "POSTGRES_SEEDS=postgresql"
- "ES_SEEDS=elasticsearch"
- "ES_VERSION=v7"
- "PERSISTENCE_TYPE=sql"
- "PERSISTENCE_DRIVER=postgres"
- "TEST_RUN_COUNT=10"
- "TEMPORAL_VERSION_CHECK_DISABLED=1"
depends_on:
- postgresql
- elasticsearch
volumes:
- ../../.testoutput:/temporal/.testoutput
networks:
services-network:
aliases:
- integration-test-xdc
integration-test-xdc-postgresql-pgx:
build:
context: ../..
dockerfile: ./develop/buildkite/Dockerfile
environment:
- "POSTGRES_SEEDS=postgresql"
- "ES_SEEDS=elasticsearch"
- "ES_VERSION=v7"
- "PERSISTENCE_TYPE=sql"
- "PERSISTENCE_DRIVER=postgres_pgx"
- "TEST_RUN_COUNT=10"
- "TEMPORAL_VERSION_CHECK_DISABLED=1"
depends_on:
- postgresql
- elasticsearch
volumes:
- ../../.testoutput:/temporal/.testoutput
networks:
services-network:
aliases:
- integration-test-xdc
integration-test-xdc-postgresql12:
build:
context: ../..

View File

@@ -17,10 +17,7 @@ steps:
- integration-test-cassandra
- integration-test-cassandra-es8
- integration-test-cassandra-opensearch
- integration-test-mysql
- integration-test-mysql8
- integration-test-postgresql
- integration-test-postgresql-pgx
- integration-test-postgresql12
- integration-test-postgresql12-pgx
- integration-test-sqlite
@@ -204,70 +201,6 @@ steps:
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional test with mysql"
agents:
queue: "default"
docker: "*"
command: "make functional-test-coverage"
parallelism: 3
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-mysql
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional xdc test with mysql"
agents:
queue: "default"
docker: "*"
command: "make functional-test-xdc-coverage"
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-xdc-mysql
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional ndc test with mysql"
agents:
queue: "default"
docker: "*"
command: "make functional-test-ndc-coverage"
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-xdc-mysql
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional test with mysql 8"
agents:
queue: "default"
@@ -332,134 +265,6 @@ steps:
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional test with postgresql"
agents:
queue: "default"
docker: "*"
command: "make functional-test-coverage"
parallelism: 3
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-postgresql
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional xdc test with postgresql"
agents:
queue: "default"
docker: "*"
command: "make functional-test-xdc-coverage"
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-xdc-postgresql
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional ndc test with postgresql"
agents:
queue: "default"
docker: "*"
command: "make functional-test-ndc-coverage"
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-xdc-postgresql
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional test with postgresql pgx"
agents:
queue: "default"
docker: "*"
command: "make functional-test-coverage"
parallelism: 3
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-postgresql-pgx
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional xdc test with postgresql pgx"
agents:
queue: "default"
docker: "*"
command: "make functional-test-xdc-coverage"
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-xdc-postgresql-pgx
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional ndc test with postgresql pgx"
agents:
queue: "default"
docker: "*"
command: "make functional-test-ndc-coverage"
artifact_paths:
- ".testoutput/*"
retry:
automatic:
limit: 1
plugins:
- artifacts#v1.9.0:
download: "develop/buildkite/*"
- ecr#v2.7.0: {login: true}
- docker-compose#v4.14.0:
run: integration-test-xdc-postgresql-pgx
config: ./develop/buildkite/docker-compose.yml
skip-checkout: true
mount-buildkite-agent: true
propagate-environment: true
- label: ":golang: functional test with postgresql 12"
agents:
queue: "default"