Github/temporal
1
0
Fork 0
mirror of https://github.com/temporalio/temporal.git synced 2026-08-30 18:41:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Optimize Visibility PostgreSQL upgrade schema v1.14 (#11599)

Browse Source 
## What changed?
Apply same optimizations in
https://github.com/temporalio/temporal/pull/10371 for v1.14.

## Why?
Better upgrade script.

## How did you test it?
- [ ] built
- [ ] run locally and tested manually
- [x] covered by existing tests
- [ ] added new unit test(s)
- [ ] added new functional test(s)

## Potential risks
This commit is contained in:
Rodrigo Zhou
2026-08-17 15:32:07 -07:00
committed by GitHub
parent 80e71af034
commit f3ebe4f99f
1 changed files with 27 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
schema/postgresql/v12/visibility/versioned/v1.14/add_external_payload_size_and_count_search_attributes.sql
View File

@@ -1,9 +1,31 @@
ALTER TABLE executions_visibility ALTER TABLE executions_visibility
ADD COLUMN TemporalExternalPayloadSizeBytes BIGINT GENERATED ALWAYS AS ((search_attributes->'TemporalExternalPayloadSizeBytes')::bigint) STORED; ADD COLUMN IF NOT EXISTS TemporalExternalPayloadSizeBytes BIGINT GENERATED ALWAYS AS ((search_attributes->'TemporalExternalPayloadSizeBytes')::bigint) STORED,
ADD COLUMN IF NOT EXISTS TemporalExternalPayloadCount BIGINT GENERATED ALWAYS AS ((search_attributes->'TemporalExternalPayloadCount')::bigint) STORED;
ALTER TABLE executions_visibility -- Drop invalid indices
ADD COLUMN TemporalExternalPayloadCount BIGINT GENERATED ALWAYS AS ((search_attributes->'TemporalExternalPayloadCount')::bigint) STORED; DO LANGUAGE 'plpgsql' $$
DECLARE
r RECORD;
BEGIN
FOR r IN
SELECT i.relname as indexname
FROM
pg_class i,
pg_index ix
WHERE
i.oid = ix.indexrelid
AND ix.indrelid = (SELECT oid FROM pg_class WHERE relname = 'executions_visibility')
AND i.relname IN (
'by_temporal_external_payload_size_bytes',
'by_temporal_external_payload_count'
)
AND NOT ix.indisvalid
LOOP
EXECUTE format('DROP INDEX %I', r.indexname);
RAISE NOTICE 'Dropped invalid index %', r.indexname;
END LOOP;
END $$;
CREATE INDEX by_temporal_external_payload_size_bytes ON executions_visibility (namespace_id, TemporalExternalPayloadSizeBytes, (COALESCE(close_time, '9999-12-31 23:59:59')) DESC, start_time DESC, run_id);
CREATE INDEX by_temporal_external_payload_count ON executions_visibility (namespace_id, TemporalExternalPayloadCount, (COALESCE(close_time, '9999-12-31 23:59:59')) DESC, start_time DESC, run_id); CREATE INDEX CONCURRENTLY IF NOT EXISTS by_temporal_external_payload_size_bytes ON executions_visibility (namespace_id, TemporalExternalPayloadSizeBytes, (COALESCE(close_time, '9999-12-31 23:59:59')) DESC, start_time DESC, run_id);
CREATE INDEX CONCURRENTLY IF NOT EXISTS by_temporal_external_payload_count ON executions_visibility (namespace_id, TemporalExternalPayloadCount, (COALESCE(close_time, '9999-12-31 23:59:59')) DESC, start_time DESC, run_id);