Github/temporal
1
0
Fork 0
mirror of https://github.com/temporalio/temporal.git synced 2026-08-30 18:41:49 -07:00
Code Issues Packages Projects Releases Wiki Activity

Switch from docker-compose to docker compose (#5314)

Browse Source 
## What changed?
<!-- Describe what has changed in this PR -->
Switch from `docker-compose` to `docker compose`.

## Why?
<!-- Tell your future self why have you made these changes -->
`docker-compose` was deprecated some time ago.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Run locally.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No risks.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
This commit is contained in:
Alex Shtin
2024-01-22 17:21:05 -08:00
committed by GitHub
parent db43a19d0d
commit 448db39cd6
5 changed files with 15 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
develop/buildkite/README.md
View File

@@ -10,11 +10,11 @@ Create an empty directory at `/usr/bin/buildkite-agent`. This directory is mount
present for the container to start.
### Run Locally
To run tests locally use `docker-compose run` command in `develop/buildkite` directory:
To run tests locally use `docker compose run` command in `develop/buildkite` directory:
```bash
cd develop/buildkite
docker-compose run <container_name> <command>
docker compose run <container_name> <command>
```
Get `<container_name>` and `<command>` form [pipeline.yml](pipeline.yml):
@@ -37,15 +37,15 @@ Get `<container_name>` and `<command>` form [pipeline.yml](pipeline.yml):
For example to run unit tests:
```bash
docker-compose run unit-test make unit-test-coverage
docker compose run unit-test make unit-test-coverage
```
or run integration tests with Cassandra:
```bash
docker-compose run integration-test-cassandra make integration-test-coverage
docker compose run integration-test-cassandra make integration-test-coverage
```
or run integration tests with MySQL:
```bash
docker-compose run integration-test-mysql make integration-test-coverage
docker compose run integration-test-mysql make integration-test-coverage
```
## Testing the build in Buildkite

4
develop/docker-compose/README.md
View File

@@ -1,6 +1,6 @@
# Temporal Server docker-compose files for server development
# Temporal Server `docker compose` files for server development
These docker-compose files run Temporal server development dependencies. Basically, they run everything you need to run
These `docker compose` files run Temporal server development dependencies. Basically, they run everything you need to run
Temporal server besides a server itself which you suppose to run locally on the host in your favorite IDE or as binary.
You are not supposed to use these files directly. Please use [Makefile](../../Makefile) targets instead. To start dependencies:

2
develop/docs/run_dependencies_host.md
View File

@@ -6,4 +6,4 @@ a bad docker file system performance on macOS. Please follow the doc for the dat
[Cassandra](macos/cassandra.md), [MySQL](macos/mysql.md), or [PostgreSQL](macos/postgresql.md).
### Linux
Linux users should use `docker-compose` as described in the [contribution guide](../../CONTRIBUTING.md).
Linux users should use `docker compose` as described in the [contribution guide](../../CONTRIBUTING.md).